Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore ingress #9956

Closed
wants to merge 3 commits into from
Closed

Ignore ingress #9956

wants to merge 3 commits into from

Conversation

YngveMolnes
Copy link

What this PR does / why we need it:

#7546
#4781

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

#7546
#4781

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2023 •
edited
Loading

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: YngveMolnes
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @YngveMolnes!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @YngveMolnes. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2023
@longwuyuan
Copy link
Contributor

@YngveMolnes thanks.

Please edit the description of this PR in such a way that a reader can understand the problem that is solved by this PR.

You have linked 2 issues but there is no text to read as to how the 2 issues are related to the current codebase, because the 2 issues are older than 2-3 years and webhook related problems are often caused by port 8443 not working as well. Deleteting the validation causes invalid ingress rules so that is another factor.

Spazzy757
Spazzy757 reviewed May 15, 2023
View reviewed changes
pkg/flags/flags.go Outdated
FakeCertificate: &ingress.SSLCert{},
SyncRateLimit: *syncRateLimit,
DisableCatchAll: *disableCatchAll,
IngressClassConfiguration: &ingressclass.IngressClassConfiguration{Controller: *ingressClassController, AnnotationValue: *ingressClassAnnotation, WatchWithoutClass: *watchWithoutClass, IngressClassByName: *ingressClassByName},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also maybe revert the formatting of this as it is a lot harder to read in a single line

@YngveMolnes
Copy link
Author

@longwuyuan yeah, It's just a draft right now - I have some cleanup, documentation and testing to do before finishing it. Continuing on it this week an next. We've been successfully running this in production for a while at $work.

@YngveMolnes YngveMolnes force-pushed the 171-annotation-validation-patch branch from 50abf7e to 7634db8 Compare May 24, 2023 11:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 24, 2023
Yngve Molnes added 2 commits May 24, 2023 13:46
# This is a combination of 5 commits.
3eed9f3 
# This is the 1st commit message:

Add feature flag to disable annotation prefix check in admission controller

# This is the commit message kubernetes#2:

Add log message for when ingress hits annotation check

Indicates that the correct environment variable is set. Does not log on
absence of environment variable.

# This is the commit message kubernetes#3:

Add flag for disabling legacy ingress class annotation prefix check

# This is the commit message kubernetes#4:

Remove negation from if statement on annotation prefix check

# This is the commit message kubernetes#5:

Add logline to indicate annotation prefix check is skipped
Fix broken rebase
5c13e93
@YngveMolnes YngveMolnes force-pushed the 171-annotation-validation-patch branch from 6676f5a to 5c13e93 Compare May 25, 2023 10:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2023
@rikatz
Copy link
Contributor

rikatz commented Feb 27, 2024

/close
This hasn't been touched for a while, closing. Let me know if this is still a thing, and in this case please open a new PR

Thanks!

@k8s-ci-robot
Copy link
Contributor

@rikatz: Closed this PR.

In response to this:

/close
This hasn't been touched for a while, closing. Let me know if this is still a thing, and in this case please open a new PR

Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spazzy757 Spazzy757 Spazzy757 left review comments

@cpanato cpanato Awaiting requested review from cpanato

@puerco puerco Awaiting requested review from puerco

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YngveMolnes @k8s-ci-robot @longwuyuan @rikatz @Spazzy757