Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote descheduler to 1.20 (with multi-arch images) #1477

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Promote descheduler to 1.20 (with multi-arch images) #1477

merged 1 commit into from
Dec 10, 2020

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Dec 10, 2020

Previous 1.19 image: #1201

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 10, 2020
damemi
damemi commented Dec 10, 2020
View reviewed changes
Copy link
Contributor Author

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @seanmalloy @ingvagabund

@k8s-ci-robot
Copy link
Contributor

@damemi: GitHub didn't allow me to request PR reviews from the following users: seanmalloy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @seanmalloy @ingvagabund

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Dec 10, 2020
@k8s-ci-robot k8s-ci-robot added wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2020
@damemi damemi mentioned this pull request Dec 10, 2020
Closed
soltysh
soltysh approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold
for final look from @seanmalloy

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2020
seanmalloy
seanmalloy approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@seanmalloy seanmalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, seanmalloy, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damemi
Copy link
Contributor Author

damemi commented Dec 10, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit b166dcc into kubernetes:master Dec 10, 2020
@damemi damemi deleted the descheduler-1.20 branch December 10, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalloy seanmalloy seanmalloy approved these changes

@soltysh soltysh soltysh approved these changes

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@thockin thockin Awaiting requested review from thockin

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damemi @k8s-ci-robot @soltysh @seanmalloy