audit: update as of 2021-03-03 #1748
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,23 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "organizations/758905017065/roles/StorageBucketLister" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "organizations/758905017065/roles/audit.viewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "organizations/758905017065/roles/organization.admin" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
|
|
@@ -27,37 +40,49 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/billing.user" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "roles/billing.viewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]", | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "roles/browser" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/compute.viewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/dns.reader" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/iam.organizationRoleAdmin" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/iam.securityReviewer" | ||
| }, | ||
|
|
@@ -69,9 +94,10 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
|
There was a problem hiding this comment. this was not me I would suggest LF use our groups, but we're also in here as backup "just in case" so I don't really mind |
||
| "user:[email protected]", | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
|
|
@@ -80,31 +106,42 @@ | |
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/resourcemanager.organizationViewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/resourcemanager.projectCreator" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/resourcemanager.projectDeleter" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "group:[email protected]" | ||
| ], | ||
| "role": "roles/secretmanager.viewer" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/servicemanagement.quotaAdmin" | ||
| }, | ||
| { | ||
| "members": [ | ||
| "user:[email protected]", | ||
| "user:[email protected]" | ||
| ], | ||
| "role": "roles/serviceusage.serviceUsageConsumer" | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "description": "View access to billing info", | ||
|
There was a problem hiding this comment. role changes are also #1726 unless commented others There was a problem hiding this comment. oops I changed the description of this a bit, should be fine? I still don't understand the exact nature of why this role has the permissions it does, I've commented as much in its spec https://github.com/kubernetes/k8s.io/blob/986809ca3832cc0432732b7f183f6354f608287e/infra/gcp/roles/specs/CustomRole.yaml |
||
| "includedPermissions": [ | ||
| "billing.accounts.getSpendingInformation", | ||
| "billing.budgets.get", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was #1726 (as well as all other changes in this file unless I comment otherwise)
specifically the part where I was paranoid about accidentally locking out k8s-infra-gcp-org-admins@ when I consolidate their roles into a single custom role
these will be removed by deployment of #1737