terraform: update secret iam to depend on secrets #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a subtle ordering bug that appears to only surface when new secrets are created. The workaround was to just keep re-running `terraform apply` until it worked The first time I ran `terraform apply` for k8s-infra-prow-build, there were secrets to be created, and then iam bindings to be applied on those secrets. But terraform didn't know about that ordering, because the iam bindings depended on the same locals that the secrets did, so terraform tried to create them all in parallel. This resulted in terraform erroring out on first run, because it was trying to create iam bindings on secrets that didn't yet exist. When I reran `terraform apply` the secrets had been created, so the iam bindings succeeded. One way to let terraform know about an ordering like this is to have one terraform resource use the value of another. Another way would be an explicit `depends_on`, but that's described as a last resort, and we're not out of options here.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
This is a subtle ordering bug that appears to only surface when new
secrets are created. The workaround was to just keep re-running
terraform applyuntil it workedThe first time I ran
terraform applyfor k8s-infra-prow-build, therewere secrets to be created, and then iam bindings to be applied on those
secrets. But terraform didn't know about that ordering, because the
iam bindings depended on the same locals that the secrets did, so
terraform tried to create them all in parallel.
This resulted in terraform erroring out on first run, because it was
trying to create iam bindings on secrets that didn't yet exist. When I
reran
terraform applythe secrets had been created, so the iambindings succeeded.
One way to let terraform know about an ordering like this is to have one
terraform resource use the value of another. Another way would be an
explicit
depends_on, but that's described as a last resort, and we'renot out of options here.