-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for content in config #1952
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jvitor83 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks amazing! Could you please update the documentation matrix as well for compatibility?
I believe we need to add another entry there. https://github.com/kubernetes/kompose/blob/main/docs/conversion.md
Otherwise, awesome code / changes and AMAZING tests. Big thanks!
Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages. The list of commits with invalid commit messages:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Done as asked! |
Closes #1947
What type of PR is this?
/kind feature
What this PR does / why we need it:
Added support to
content
inconfig
element.Unit test included.
Which issue(s) this PR fixes:
Fixes #1947