If using boskos, always create a new GCS bucket

Previously we were setting KOPS_STATE_STORE before knowing its value, resulting in an empty string

tests/e2e/kubetest2-kops/deployer/build.go

@@ -78,12 +78,6 @@ func (d *deployer) verifyBuildFlags() error {
 
 	d.BuildOptions.KopsRoot = d.KopsRoot
 	d.BuildOptions.StageLocation = d.StageLocation
-	for _, envvar := range d.env() {
-		// Set all of the env vars we use for kops in the current process
-		// so that the tester inherits them when shelling out to kops
-		i := strings.Index(envvar, "=")
-		os.Setenv(envvar[0:i], envvar[i+1:])
-	}
 	return nil
 }
 

tests/e2e/kubetest2-kops/deployer/common.go

@@ -106,7 +106,7 @@ func (d *deployer) initialize() error {
 				d.SSHPrivateKeyPath = privateKey
 				d.SSHPublicKeyPath = publicKey
 			}
-			d.createBucket = os.Getenv("KOPS_STATE_STORE") == ""
+			d.createBucket = true
 		}
 	}
 	if d.SSHUser == "" {
@@ -119,6 +119,14 @@ func (d *deployer) initialize() error {
 		}
 		d.terraform = t
 	}
+	if d.commonOptions.ShouldTest() {
+		for _, envvar := range d.env() {
+			// Set all of the env vars we use for kops in the current process
+			// so that the tester inherits them when shelling out to kops
+			i := strings.Index(envvar, "=")
+			os.Setenv(envvar[0:i], envvar[i+1:])
+		}
+	}
 	return nil
 }