Kops should be able to add annotations

[lucascollino]

Hi, similar to #742 I need to add annotations to nodes (from the instance group yaml) for managing the update-operator, in the same way labels are.

Something equivalent to this, but with annotations:

spec:
  nodeLabels:
    kubernetes.io/role: node

Maybe it's already in place or planned, but didn't find it in the docs nor the code.

Thanks!

[chrislovecnm]

We are able to add node and cloud tags, I am not certain how this functionality differs.

You have to use yaml to maintain your clusters or edit the cluster. Here is an example https://github.com/kubernetes/kops/blob/master/tests/integration/complex/in-v1alpha2.yaml

Also the instance group documentation provides examples.

[greg-jaunt]

The example above is already possible, but the needed feature is the equivalent of the above for annotations:

apiVersion: kops/v1alpha2
kind: InstanceGroup
spec:
  nodeAnnotations:
    somekey: somevalue

Would automatically add "somekey:somevalue" to the metadata.annotation map on every launched node in that instance group.

[Z3r0Sum]

@greg-jaunt nvm - you said it's needed, my fault.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[adammw]

/reopen

Annotations are often required for various daemonsets running on the nodes for configuration, for example the eniConfig annotation is required for the AWS CNI plugin: aws/amazon-vpc-cni-k8s#165

[k8s-ci-robot]

@adammw: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Annotations are often required for various daemonsets running on the nodes for configuration, for example the eniConfig annotation is required for the AWS CNI plugin: aws/amazon-vpc-cni-k8s#165

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lucascollino]

/reopen

for @adammw comment

[k8s-ci-robot]

@lucascollino: Reopening this issue.

In response to this:

/reopen

for @adammw comment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[semoac]

This will be awesome to automatize thing like routeReflector on calico.