Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace * in IAM tags when IRSA namespace has wildcard #16113

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

h3poteto
Copy link
Contributor

fix: #16027

I think * char is allowed in namespace of IRSA, so it should be possible to create.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 19, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2023
@h3poteto h3poteto marked this pull request as ready for review November 19, 2023 15:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2023
@hakman
Copy link
Member

hakman commented Nov 19, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 19, 2023
@h3poteto
Copy link
Contributor Author

/test pull-kops-test

@hakman
Copy link
Member

hakman commented Nov 20, 2023

@h3poteto To update golden output automatically, run hack/update-expected.sh:

+     "service-account.kops.k8s.io/namespace"     = "test-wildcard"
-     "service-account.kops.k8s.io/namespace"     = "test-*"

@hakman
Copy link
Member

hakman commented Nov 20, 2023

Thanks @h3poteto.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit bcbf6c7 into kubernetes:master Nov 20, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 20, 2023
k8s-ci-robot added a commit that referenced this pull request Nov 21, 2023
…-upstream-release-1.28

Automated cherry pick of #16113: Replace * in IAM tags when IRSA namespace has wildcard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRSA - Can't create IAM role when namespace has wildcard char
3 participants