chore(karpenter): upgrade karpenter to v0.32.6 #16327

moshevayner · 2024-02-07T21:20:13Z

What this PR does / why we need it:
Bumps karpenter version to 0.32.6

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
fixes #16311

Special notes for your reviewer:
Release page

moshevayner · 2024-02-07T22:20:29Z

/test all

hakman · 2024-02-08T03:29:19Z

upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template

-              - key: kubernetes.io/os
-                operator: In
-                values:
-                - linux
              - key: karpenter.sh/provisioner-name
                operator: DoesNotExist
-              - key: node-role.kubernetes.io/control-plane
-                operator: Exists
-            - matchExpressions:
-              - key: kubernetes.io/os
-                operator: In
-                values:
-                - linux
-              - key: karpenter.sh/provisioner-name
+              - key: karpenter.sh/nodepool
                operator: DoesNotExist
-              - key: node-role.kubernetes.io/master
-                operator: Exists


This block has to be reverted.

hakman · 2024-02-08T03:29:32Z

upup/models/cloudup/resources/addons/karpenter.sh/k8s-1.19.yaml.template

-        - key: node-role.kubernetes.io/master
-          operator: Exists
-        - key: node-role.kubernetes.io/control-plane
-          operator: Exists


This block has to be reverted.

Yeah, that makes sense. I must've overlooked those, and that could make sense as to why the tests are failing.
Let me give that a try.
Thanks for catching that!

k8s-ci-robot · 2024-02-08T03:43:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hakman. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

moshevayner · 2024-02-08T03:43:32Z

/retest

moshevayner · 2024-02-08T04:41:33Z

/retest

hakman · 2024-02-08T05:30:15Z

I guess CRDs need updating:

I0208 05:04:17.581270    5067 addon.go:192] Applying update from "s3://k8s-kops-prow/e2e-pr16327.pull-kops-e2e-aws-karpenter.test-cncf-aws.k8s.io/addons/karpenter.sh/k8s-1.19.yaml"
I0208 05:04:17.581294    5067 s3fs.go:378] Reading file "s3://k8s-kops-prow/e2e-pr16327.pull-kops-e2e-aws-karpenter.test-cncf-aws.k8s.io/addons/karpenter.sh/k8s-1.19.yaml"
W0208 05:04:17.942636    5067 health.go:69] expected status.conditions to be list, got <nil>
W0208 05:04:17.989700    5067 health.go:69] expected status.conditions to be list, got <nil>
W0208 05:04:18.004385    5067 health.go:69] expected status.conditions to be list, got <nil>
W0208 05:04:18.037816    5067 health.go:69] expected status.conditions to be list, got <nil>
W0208 05:04:18.104261    5067 health.go:69] expected status.conditions to be list, got <nil>
W0208 05:04:18.185098    5067 health.go:69] expected status.conditions to be list, got <nil>
I0208 05:04:18.279025    5067 health.go:63] status conditions not found for PodDisruptionBudget.policy:kube-system/karpenter
I0208 05:04:18.478384    5067 health.go:63] status conditions not found for Secret:kube-system/karpenter-cert
I0208 05:04:19.883033    5067 health.go:63] status conditions not found for Service:kube-system/karpenter
I0208 05:04:19.982831    5067 health.go:63] status conditions not found for Deployment.apps:kube-system/karpenter
I0208 05:04:20.081517    5067 health.go:63] status conditions not found for MutatingWebhookConfiguration.admissionregistration.k8s.io:defaulting.webhook.karpenter.k8s.aws
I0208 05:04:20.178238    5067 health.go:63] status conditions not found for ValidatingWebhookConfiguration.admissionregistration.k8s.io:validation.webhook.karpenter.sh
I0208 05:04:20.277927    5067 health.go:63] status conditions not found for ValidatingWebhookConfiguration.admissionregistration.k8s.io:validation.webhook.config.karpenter.sh
I0208 05:04:20.376625    5067 health.go:63] status conditions not found for ValidatingWebhookConfiguration.admissionregistration.k8s.io:validation.webhook.karpenter.k8s.aws
W0208 05:04:20.376686    5067 results.go:63] error from apply on karpenter.k8s.aws/v1alpha1, Kind=AWSNodeTemplate /nodes: error getting rest mapping for karpenter.k8s.aws/v1alpha1, Kind=AWSNodeTemplate: no matches for kind "AWSNodeTemplate" in version "karpenter.k8s.aws/v1alpha1"
W0208 05:04:20.376713    5067 results.go:63] error from apply on karpenter.sh/v1beta1, Kind=NodePool /nodes: error getting rest mapping for karpenter.sh/v1beta1, Kind=NodePool: no matches for kind "NodePool" in version "karpenter.sh/v1beta1"
W0208 05:04:20.376746    5067 results.go:56] consistency error (healthy counts): &applyset.ApplyResults{total:30, applySuccessCount:28, applyFailCount:2, healthyCount:28, unhealthyCount:0}

k8s-triage-robot · 2024-06-12T14:08:52Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-ci-robot · 2024-07-06T06:30:13Z

@moshevayner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-aws-upgrade-k127-ko127-to-k128-kolatest-karpenter	`3a76e1f`	link	false	`/test pull-kops-e2e-aws-upgrade-k127-ko127-to-k128-kolatest-karpenter`
pull-kops-e2e-aws-karpenter	`3a76e1f`	link	true	`/test pull-kops-e2e-aws-karpenter`
pull-kops-e2e-k8s-aws-calico-k8s-infra	`3a76e1f`	link	true	`/test pull-kops-e2e-k8s-aws-calico-k8s-infra`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-triage-robot · 2024-08-05T07:14:57Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

hakman · 2024-08-15T13:34:06Z

/remove-lifecycle rotten

guanchzhou · 2024-09-19T13:14:07Z

Under the lights of #16758 is this PR still needed?

hakman · 2024-09-19T15:06:19Z

Under the lights of #16758 is this PR still needed?

I think @rifelpet's PR is a more advanced version. Also, I think @moshevayner is pretty busy these days.
Closing for now.
/close

k8s-ci-robot · 2024-09-19T15:06:26Z

@hakman: Closed this PR.

In response to this:

Under the lights of #16758 is this PR still needed?

I think @rifelpet's PR is a more advanced version. Also, I think @moshevayner is pretty busy these days.
Closing for now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

moshevayner · 2024-10-06T18:46:13Z

Under the lights of #16758 is this PR still needed?

I think @rifelpet's PR is a more advanced version. Also, I think @moshevayner is pretty busy these days. Closing for now. /close

Thanks @hakman !
Indeed I've been a bit off the grid lately.. Hoping to be able to get back on soon 🙏🏼

hakman · 2024-10-06T18:50:09Z

Welcome back @moshevayner! 😄

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 7, 2024

k8s-ci-robot requested review from hakman and zetaab February 7, 2024 21:22

k8s-ci-robot added area/addons area/api labels Feb 7, 2024

moshevayner marked this pull request as draft February 7, 2024 21:28

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024

moshevayner force-pushed the 16311-upgrade-karpenter-0.32.6 branch from 60e2ba7 to bee8cb3 Compare February 7, 2024 22:06

hakman requested changes Feb 8, 2024

View reviewed changes

k8s-ci-robot assigned hakman Feb 8, 2024

moshevayner force-pushed the 16311-upgrade-karpenter-0.32.6 branch from bee8cb3 to 7b7400c Compare February 8, 2024 03:42

moshevayner added 3 commits February 7, 2024 23:38

upgrade karpenter to version 0.32.6

46b06d2

make crds apimachinery

d6a8d80

hack/update-expected

3a76e1f

moshevayner force-pushed the 16311-upgrade-karpenter-0.32.6 branch from 7b7400c to 3a76e1f Compare February 8, 2024 04:41

moshevayner changed the base branch from master to dependencies/update-1658470204 February 11, 2024 21:31

hakman changed the base branch from dependencies/update-1658470204 to master March 14, 2024 13:23

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 5, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 15, 2024

k8s-ci-robot closed this Sep 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(karpenter): upgrade karpenter to v0.32.6 #16327

chore(karpenter): upgrade karpenter to v0.32.6 #16327

moshevayner commented Feb 7, 2024

moshevayner commented Feb 7, 2024

hakman Feb 8, 2024

hakman Feb 8, 2024

moshevayner Feb 8, 2024

k8s-ci-robot commented Feb 8, 2024

moshevayner commented Feb 8, 2024

moshevayner commented Feb 8, 2024

hakman commented Feb 8, 2024

k8s-triage-robot commented Jun 12, 2024

k8s-ci-robot commented Jul 6, 2024

k8s-triage-robot commented Aug 5, 2024

hakman commented Aug 15, 2024

guanchzhou commented Sep 19, 2024

hakman commented Sep 19, 2024

k8s-ci-robot commented Sep 19, 2024

moshevayner commented Oct 6, 2024

hakman commented Oct 6, 2024

chore(karpenter): upgrade karpenter to v0.32.6 #16327

chore(karpenter): upgrade karpenter to v0.32.6 #16327

Conversation

moshevayner commented Feb 7, 2024

moshevayner commented Feb 7, 2024

hakman Feb 8, 2024

Choose a reason for hiding this comment

hakman Feb 8, 2024

Choose a reason for hiding this comment

moshevayner Feb 8, 2024

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 8, 2024

moshevayner commented Feb 8, 2024

moshevayner commented Feb 8, 2024

hakman commented Feb 8, 2024

k8s-triage-robot commented Jun 12, 2024

k8s-ci-robot commented Jul 6, 2024

k8s-triage-robot commented Aug 5, 2024

hakman commented Aug 15, 2024

guanchzhou commented Sep 19, 2024

hakman commented Sep 19, 2024

k8s-ci-robot commented Sep 19, 2024

moshevayner commented Oct 6, 2024

hakman commented Oct 6, 2024