Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotinst: Bump k8s cluster controller to v2 #16717

Merged
merged 3 commits into from
Aug 9, 2024
Merged

spotinst: Bump k8s cluster controller to v2 #16717

merged 3 commits into from
Aug 9, 2024

Conversation

yehielnetapp
Copy link
Contributor

update controller v2, inform user on conflict with AWS nodeTerminationHandler and Ocean

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @yehielnetapp. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Aug 1, 2024
@hakman
Copy link
Member

hakman commented Aug 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2024
@olemarkus
Copy link
Member

/lgtm
/assign @hakman

I'd like more eyes on this one.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2024
hakman
hakman approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yehielnetapp & @olemarkus!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2024
@hakman hakman changed the title Spotinst/feature/bump k8s cluster controller to v2 spotinst: Bump k8s cluster controller to v2 Aug 9, 2024
@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5d4d867 into kubernetes:master Aug 9, 2024
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Aug 9, 2024
rsafonseca pushed a commit to rsafonseca/kops that referenced this pull request Oct 24, 2024
@yehielnetapp @rsafonseca
spotinst: Bump k8s cluster controller to v2 (kubernetes#16717)
f57f734 
* update controller v2, inform user on conflict with aws nodeTerminationHandler and Ocean

* add BuildPrune to addon,tested

* add note to release 1.31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman approved these changes

@zetaab zetaab Awaiting requested review from zetaab

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
4 participants
@yehielnetapp @k8s-ci-robot @hakman @olemarkus