Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hpa): status current metric #1725

Merged

Conversation

tanguyfalconnet
Copy link
Contributor

@tanguyfalconnet tanguyfalconnet commented Apr 29, 2022

Signed-off-by: Tanguy Falconnet [email protected]

What this PR does / why we need it:

We want to be able to have current status of target metrics used by HPA.
We are currently not able to know if our HPA target metrics are healthy or in <unknown> state. Used in pair with prometheus-adapter for custom metric scaling, this is an important metric to check to monitor our clusters.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Increases, as it adds a new metric kube_horizontalpodautoscaler_status_current_target_metric, mostly the same as kube_horizontalpodautoscaler_spec_target_metric

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 29, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @tanguyfalconnet!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2022
@tanguyfalconnet tanguyfalconnet changed the title feat(hpa): status current target feat(hpa): status current metric Apr 29, 2022
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good so far, just a few nits from my side

internal/store/horizontalpodautoscaler.go Outdated Show resolved Hide resolved
internal/store/horizontalpodautoscaler.go Outdated Show resolved Hide resolved
@fpetkovski
Copy link
Contributor

Thanks for the contribution. Could you you also sign the CLA so that we can make the CI green?

You can squash all your commits and run

git commit --amend --no-edit --signoff

@tanguyfalconnet
Copy link
Contributor Author

Thanks for the contribution. Could you you also sign the CLA so that we can make the CI green?

You can squash all your commits and run

git commit --amend --no-edit --signoff

CLA is being reviewed by my company. I'll sign it when everything is ready on our side. Next time it'll go faster ^^

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2022
@mrueg
Copy link
Member

mrueg commented Jul 19, 2022

@tanguyfalconnet do you have an update from your company on the CLA?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 20, 2022
@tanguyfalconnet
Copy link
Contributor Author

tanguyfalconnet commented Jul 20, 2022

@mrueg It's finally ok. It seems that similar code is already merged. I'll let you close it/merge it as you wish.

@mrueg
Copy link
Member

mrueg commented Jul 20, 2022

Thanks for the update @tanguyfalconnet!
We're waiting on a response from the author of #1788 (comment) to make sure that it's clear where this code is coming from. So I'll keep this open so we can still use it to ensure correct authorship.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2022
@mrueg
Copy link
Member

mrueg commented Aug 9, 2022

/lgtm

/hold
for @fpetkovski @dgrisonnet to take a look.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2022
@dgrisonnet
Copy link
Member

Thank you for looking into this @tanguyfalconnet.

/lgtm
/approve
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg, tanguyfalconnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 767af98 into kubernetes:master Aug 9, 2022
@mrueg mrueg mentioned this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants