-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch registry from k8s.gcr.io to registry.k8s.io #1750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Jun 7, 2022
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jun 7, 2022
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 7, 2022
Signed-off-by: Manuel Rüger <[email protected]>
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 7, 2022
@fpetkovski can you LGTM again? thanks! |
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jun 7, 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
6 tasks
olivierlemasle
added a commit
to olivierlemasle/kube-prometheus
that referenced
this pull request
Oct 24, 2022
Kubernetes has switched registry from k8s.gcr.io to registry.k8s.io in kubernetes/kubernetes#109938. kube-state-metrics also did the switch in kubernetes/kube-state-metrics#1750. This commit also updates the registry in a kubeadm configuration example.
5 tasks
olivierlemasle
added a commit
to olivierlemasle/cluster-monitoring-operator
that referenced
this pull request
Nov 2, 2022
Kubernetes has switched registry from k8s.gcr.io to registry.k8s.io in kubernetes/kubernetes#109938. kube-state-metrics also did the switch in kubernetes/kube-state-metrics#1750. Signed-off-by: Olivier Lemasle <[email protected]>
philipgough
pushed a commit
to prometheus-operator/kube-prometheus
that referenced
this pull request
Nov 7, 2022
Kubernetes has switched registry from k8s.gcr.io to registry.k8s.io in kubernetes/kubernetes#109938. kube-state-metrics also did the switch in kubernetes/kube-state-metrics#1750. This commit also updates the registry in a kubeadm configuration example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use new domain for k8s image registry, as per https://groups.google.com/a/kubernetes.io/g/dev/c/DYZYNQ_A6_c/m/FpHqeVR2BAAJ
More context: kubernetes/kubernetes#109938
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None