-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump prometheus/common library #2352
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knabben, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@knabben |
@mrueg It was for a specific case; I apologize if you were expecting other assigned reviewers. I'm not sure if I have the bandwidth to collaborate on the project actively. |
@knabben Yes, the expectation in general is that contributors would lgtm pull requests and not unrelated members of the kubernetes org (and if they do it, then they would usually provide some context why). Was there any specific bug or issue that you saw that this PR fixes? |
Sorry folks, I reached out on the CNCF Ambassador channel to ask if there was any maintainer of this project present who could approved this, as our (internal) project includes some modules from this repo, and we were blocked (importing 2 modules of different versions, the usual). I did not mean to cause any issue here 🙏 Thank you for merging this though! |
What this PR does / why we need it:
In later releases of prometheus/common FormatStrings got unexported to allow to check for more permutations with other features encoded in the contentType.
prometheus/common#576
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
None
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #