fix: set kube_job_status_failed metric even when there are no job.Status.Conditions present

[richabanker]

What this PR does / why we need it:
Sets the kube_job_status_failed metric when a job's conditions are empty. Previously, the metric was only being set while iterating through a job's conditions, thus ignoring the case when no conditions were found but the job still failed.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
does not change

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2443

[dgrisonnet]

Looks good to me, but could you please add a new test in https://github.com/kubernetes/kube-state-metrics/blob/194a46c09999771736a6e93d8ec48b38219df55e/internal/store/job_test.go to verify that jobs without failed condition have metrics generated?

[richabanker]

Looks good to me, but could you please add a new test in https://github.com/kubernetes/kube-state-metrics/blob/194a46c09999771736a6e93d8ec48b38219df55e/internal/store/job_test.go to verify that jobs without failed condition have metrics generated?

Yep, for sure. Added one, thanks!

[richabanker]

Hmm, super weird, when I run make test-unit locally - its passing all tests but CI is complaining :/

Edit: Just needed a rebase with upstream. Fixed now.

[dashpole]

/assign @dgrisonnet
/triage accepted

[dgrisonnet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgrisonnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment