Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structured generator for kubectl autoscale #138

Closed
mengqiy opened this issue Nov 16, 2017 · 4 comments
Closed

Use structured generator for kubectl autoscale #138

mengqiy opened this issue Nov 16, 2017 · 4 comments
Assignees
@mengqiy
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@mengqiy
Copy link
Member

mengqiy commented Nov 16, 2017 •
edited
Loading

kubectl autoscale is using parameter injection style generator at the moment.

It should implement the structured generator interface like deployment generator: https://github.com/kubernetes/kubernetes/blob/c3ed0f26636d0fc5c3905a0c09bf4886da8512c9/pkg/kubectl/deployment.go#L119-L147.
After implementing the interface, we should

  • refactor kubectl autoscale to use the new generator
  • create kubectl create hpa (optional)

When implementing the interface, make sure you generate a external type object.
@wackxu
Copy link

wackxu commented Nov 16, 2017

I can help fix it

@mengqiy
Copy link
Member Author

mengqiy commented Nov 16, 2017

Great!
I found I can't assign it to you. So I will assign it to myself for now. Ping me on slack when the PR is ready or you have some question.

@mengqiy mengqiy self-assigned this Nov 16, 2017
@wackxu
Copy link

wackxu commented Nov 16, 2017

@mengqiy Ok, Thanks

This was referenced Nov 17, 2017
Merged
Closed
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Dec 14, 2017
Merge pull request #55913 from wackxu/refauto
8e16121 
Automatic merge from submit-queue (batch tested with PRs 55900, 55995, 55913, 55467, 55376). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use structured generator for kubectl autoscale

**What this PR does / why we need it**:

Use structured generator for kubectl autoscale

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
part of  # kubernetes/kubectl#138

**Special notes for your reviewer**:
/assign @mengqiy 

**Release note**:

```release-note
Use structured generator for kubectl autoscale 
```
@k8s-ci-robot k8s-ci-robot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed for-new-contributors labels Dec 15, 2017
@mengqiy
Copy link
Member Author

mengqiy commented Feb 26, 2018

This is fixed by #55913. Closing.

@mengqiy mengqiy closed this as completed Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengqiy mengqiy

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@apelisse @mengqiy @k8s-ci-robot @wackxu