[go1.17] Update to go1.17

[justaugustus]

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

[go1.17] Update to go1.17
Tracking issue: kubernetes/release#2169

Signed-off-by: Stephen Augustus [email protected]

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built using go1.17

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[sanposhiho]

@justaugustus
I'm not familiar with test-infra repo, but isn't this CI task still configured to go on the old image(gcr.io/k8s-testimages/krte:v20210808-1eaeec7-master)?

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-testing/conformance-e2e.yaml#L64

It seems some people also run test many times but no test passes.
https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-conformance-kind-ipv6-parallel

[kerthcet]

@justaugustus
I'm not familiar with test-infra repo, but isn't this CI task still configured to go on the old image(gcr.io/k8s-testimages/krte:v20210808-1eaeec7-master)?

https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes/sig-testing/conformance-e2e.yaml#L64

It seems some people also run test many times but no test passes.
https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-conformance-kind-ipv6-parallel

+ make all WHAT=cmd/kubectl test/e2e/e2e.test vendor/github.com/onsi/ginkgo/ginkgo

Detected go version: go version go1.16.7 linux/amd64.
Kubernetes requires go1.17.0 or greater.
Please install go1.17.0 or later.

!!! [0825 05:32:34] Call tree:
!!! [0825 05:32:34]  1: hack/run-in-gopath.sh:31 kube::golang::setup_env(...)

Detected go version: go version go1.16.7 linux/amd64.
Kubernetes requires go1.17.0 or greater.
Please install go1.17.0 or later.

!!! [0825 05:32:34] Call tree:
!!! [0825 05:32:34]  1: /home/prow/go/src/k8s.io/kubernetes/hack/lib/golang.sh:793 kube::golang::setup_env(...)
!!! [0825 05:32:34]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0825 05:32:34] Call tree:
!!! [0825 05:32:34]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make[1]: *** [Makefile.generated_files:208: _output/bin/prerelease-lifecycle-gen] Error 1
make: *** [Makefile:552: generated_files] Error 2
wrapper.sh] [TEST] Test Command exit code: 2

[kerthcet]

After this PR, it seems that all CI pull-kubernetes-conformance-kind-ipv6-parallel fails with the below error.

Detected go version: go version go1.16.7 linux/amd64.
Kubernetes requires go1.17.0 or greater.
Please install go1.17.0 or later.

https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-conformance-kind-ipv6-parallel
Do we have to do something?

@sanposhiho -- The kind presubmit versions were bumped in kubernetes/test-infra#23358, but the PRs you're watching may be reporting the results of jobs using the old image. Issuing a /retest command (on a line by itself) should trigger a new test run with the correct image.

(We had to do the same for this PR a few times.)

/retest not work I think. I checked the latest branch, it seems like all the go version is upgraded to 1.17. keep tracing.

[kerthcet]

related: kubernetes/test-infra#23364

[aojea]

it is failing because the images of the CI weren't updated, the bot has to update the new images

kubernetes/test-infra#23143

[aojea]

The change is here in the queue kubernetes/test-infra#23349

[fedebongio]

/triage accepted

[medyagh]

This PR breaks kubernetes/minikube's automation that bumps the golang version to match kubernetes/kubernetes

is there any reason that 1.23.0 Prefix was added to this image?

[liggitt]

is there any reason that 1.23.0 Prefix was added to this image?

because there are more inputs to the image than just the golang version (like the protobuf generators), and we don't always want to bump those on release branches

[justaugustus]

because there are more inputs to the image than just the golang version (like the protobuf generators), and we don't always want to bump those on release branches

+1. Explained in detail in kubernetes/release#2211:

• images: Enforce Debian codenames for Golang-based images
  When there are multiple image builds in flight both upstream and downstream,
  we can run into situations where a new Debian version becomes the default for
  image builds, which can have unintended side-effects across release branches.
  Here we use explicit pairings of Golang/Debian versions to retrieve images
  Example: FROM golang:1.16.7-buster

• kube-cross: Use OS codenames to construct clearer versions for images
  Uses the following nomenclature:
  v<kubernetes-major>-go<go-major>-<os-codename>.<revision>
  Example: v1.23.0-go1.17-buster.0

[medyagh]

thanks for the explain @liggitt @justaugustus now it makes sense !

[justaugustus]

thanks for the explain @liggitt @justaugustus now it makes sense !

Happy to help, @medyagh!