Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate release infrastructure and doc - moved to kubernetes/release #24629

Merged
merged 1 commit into from
Sep 10, 2016
Merged

Deprecate release infrastructure and doc - moved to kubernetes/release #24629

merged 1 commit into from
Sep 10, 2016

Conversation

david-mcmahon
Copy link
Contributor

@david-mcmahon david-mcmahon commented Apr 21, 2016 •
edited by k8s-oncall
Loading

Part 2 of kubernetes/release#1
This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release.

ref #16529

This change is Reviewable

@david-mcmahon david-mcmahon added area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 21, 2016
@k8s-github-robot k8s-github-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 21, 2016
ikehz
ikehz reviewed Apr 21, 2016
View reviewed changes
docs/devel/releasing.md
notes draft), and attach it to the release; and
1. publish!

### Manual tasks for new release series
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, you haven't replaced any of this stuff in your new tooling, so it should probably stay/get moved over.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 is handled in the tooling and 2 is on the test team for now. When there's an interface we can work with to have the release tooling trigger a new set of jobs, we will add that to the process.

@ikehz
Copy link
Contributor

ikehz commented Apr 21, 2016

LGTM; I assume you don't want to merge it yet, though.

@david-mcmahon
Copy link
Contributor Author

Damn bot assigning! I just wanted to get the PR up into the mix, but it's definitely not ready for merging yet. It's not even completely done yet. Sorry to bother..

@ikehz
Copy link
Contributor

ikehz commented Apr 21, 2016

Damn bot assigning! I just wanted to get the PR up into the mix, but it's definitely not ready for merging yet. It's not even completely done yet. Sorry to bother..

No problem. In the future, you can assign a PR to yourself until it's ready for review. Or just label it "[WIP]". Or both.

@ikehz ikehz assigned david-mcmahon and unassigned ikehz Apr 21, 2016
@david-mcmahon
Copy link
Contributor Author

Oh, will WIP preclude the autoassigning? Good to know.

@david-mcmahon david-mcmahon changed the title Deprecate kubernetes/kubenetes release infrastructure and doc. WIP: Deprecate kubernetes/kubenetes release infrastructure and doc. Apr 21, 2016
@ikehz
Copy link
Contributor

ikehz commented Apr 22, 2016

Oh, will WIP preclude the autoassigning? Good to know.

No, but it will make it clear it's a WIP and I shouldn't review it yet. Best to assign to yourself to keep the assigner-bot away.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2016
@david-mcmahon david-mcmahon added release-note-experimental release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-none Denotes a PR that doesn't merit a release note. release-note-label-needed labels Jun 1, 2016
@david-mcmahon david-mcmahon force-pushed the release-deprecation branch 2 times, most recently from 94da9d3 to ead3e4c Compare June 10, 2016 01:39
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2016
@zmerlynn zmerlynn removed their assignment Aug 9, 2016
@spxtr spxtr mentioned this pull request Aug 15, 2016
Closed
@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2016
@david-mcmahon david-mcmahon changed the title WIP: Deprecate kubernetes/kubenetes release infrastructure and doc. Deprecate release infrastructure and doc - moved to kubernetes/release Sep 2, 2016
@david-mcmahon david-mcmahon mentioned this pull request Sep 6, 2016
Merged
@david-mcmahon
Copy link
Contributor Author

This is ready. PTAL.

@david-mcmahon david-mcmahon removed their assignment Sep 8, 2016
@ixdy
Copy link
Member

ixdy commented Sep 9, 2016

So basically this leaves build/release.sh and everything it uses, but removes the rest?

@david-mcmahon
Copy link
Contributor Author

@ixdy yes, the remaining "release" bits are the parts of the build that construct the artifacts that make up the release.

ixdy
ixdy reviewed Sep 9, 2016
View reviewed changes
build/common.sh
fi
}
###############################################################################
# The ::release:: namespace functions have been moved to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they didn't all move (hence my comment) - maybe update this comment to note that the actual release functions have moved, but the packaging ones (related to build) remain.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not sure if we intend to rename the ::release:: functions here to something like ::package::?)

@ixdy
Copy link
Member

ixdy commented Sep 9, 2016

LGTM besides comment suggestion

@david-mcmahon david-mcmahon added lgtm "Looks good to me", indicates that a PR is ready to be merged. area/build-release and removed area/build-release labels Sep 10, 2016
@k8s-bot
Copy link

k8s-bot commented Sep 10, 2016

GCE e2e build/test passed for commit 4e07b43.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 10, 2016

GCE e2e build/test passed for commit 4e07b43.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit da4f0ca into kubernetes:master Sep 10, 2016
@ixdy ixdy mentioned this pull request Sep 12, 2016
Merged
8 tasks
xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Merge pull request kubernetes#24629 from david-mcmahon/release-deprec…
f78c492 
…ation

Automatic merge from submit-queue

Deprecate release infrastructure and doc - moved to kubernetes/release

Part 2 of kubernetes/release#1
This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release.

ref kubernetes#16529
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@david-mcmahon @ikehz @spxtr @k8s-github-robot @fejta @k8s-bot @ixdy @zmerlynn @googlebot