Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in Heapster deployment for google sink #57902

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

kawych
Copy link
Contributor

@kawych kawych commented Jan 5, 2018

What this PR does / why we need it:
Fixes a bug in Heapster deployment for google sink.

Release note:

Fixes a bug in Heapster deployment for google sink.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 5, 2018
@kawych
Copy link
Contributor Author

kawych commented Jan 5, 2018

/assign @x13n

@spiffxp
Copy link
Member

spiffxp commented Jan 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2018
@x13n
Copy link
Member

x13n commented Jan 8, 2018

/approve no-issue

@x13n
Copy link
Member

x13n commented Jan 8, 2018

@kawych Nope, I'm not in OWNERS, go and approve it yourself.

@kawych
Copy link
Contributor Author

kawych commented Jan 8, 2018

/approve no-issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kawych, spiffxp, x13n

Associated issue requirement bypassed by: kawych

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 8, 2018

@kawych: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-unit 5312989 link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 57902, 57958). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 21b1e30 into kubernetes:master Jan 8, 2018
k8s-github-robot pushed a commit that referenced this pull request Jan 12, 2018
…-upstream-release-1.9

Automatic merge from submit-queue.

Automated cherry pick of #57902: Fix errors in Heapster deployment for google sink

Cherry pick of #57902 on release-1.9.

#57902: Fix errors in Heapster deployment for google sink

**Release note**:
```release-note
Fixes a bug in Heapster deployment for google sink.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants