Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable audit logging truncating backend. #68342

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Enable audit logging truncating backend. #68342

merged 1 commit into from
Sep 25, 2018

Conversation

loburm
Copy link
Contributor

@loburm loburm commented Sep 6, 2018 

[GCE] Enable by default audit logging truncating backend.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2018
@k8s-ci-robot
Copy link
Contributor

@loburm:
This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.
To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.
The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@loburm: There are no sig labels on this issue. Please add a sig label by either:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <group-name>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 6, 2018
@loburm
Copy link
Contributor Author

loburm commented Sep 6, 2018

/assign @MaciekPytel

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 6, 2018
@loburm
Copy link
Contributor Author

loburm commented Sep 6, 2018

/retest

@loburm
Copy link
Contributor Author

loburm commented Sep 12, 2018

/assign @gmarek

@loburm
Copy link
Contributor Author

loburm commented Sep 17, 2018

/retest

1 similar comment
@loburm
Copy link
Contributor Author

loburm commented Sep 17, 2018

/retest

@loburm
Copy link
Contributor Author

loburm commented Sep 20, 2018

/assign @foxish

@loburm
Copy link
Contributor Author

loburm commented Sep 21, 2018

/kind bug
Attacker can easily generate extremely large audit log lines without this option enabled.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 21, 2018
@loburm
Copy link
Contributor Author

loburm commented Sep 21, 2018

@foxish Please take a look

@foxish foxish added this to the v1.11 milestone Sep 24, 2018
@foxish foxish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. sig/gcp and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 24, 2018
@foxish
Copy link
Contributor

foxish commented Sep 24, 2018

@loburm, please get lgtm+approval from the owner(s).

@gmarek
Copy link
Contributor

gmarek commented Sep 25, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, loburm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit bcb411f into kubernetes:release-1.11 Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingax10 jingax10 Awaiting requested review from jingax10

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

Assignees

@foxish foxish

@gmarek gmarek

@MaciekPytel MaciekPytel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
5 participants
@loburm @k8s-ci-robot @foxish @gmarek @MaciekPytel