Rename cadvisor metric labels to match instrumentation guidelines

[ehashman]

What this PR does / why we need it:

Changes exported cadvisor metric labels to match the Kubernetes instrumentation guidelines.

Which issue(s) this PR fixes:

Fixes #66790.

Special notes for your reviewer:

See also the metrics overhaul KEP-0031.

Release note:

Added cadvisor metric labels `pod` and `container` where `pod_name` and `container_name` are present to match instrumentation guidelines.

Action required: any Prometheus queries that match `pod_name` and `container_name` labels (e.g. cadvisor or kubelet probe metrics) should be updated to use `pod` and `container` instead. `pod_name` and `container_name` labels will be present alongside `pod` and `container` labels for one transitional release and removed in the future.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ehashman]

/sig instrumentation
/cc @brancz

[ehashman]

/check-cla

[idealhack]

/ok-to-test
/kind bug

[coffeepac]

As discussed during F2F at KubeCon, please include both current incorrect and new desired form of the labels.

[ehashman]

Updated PR to include both sets of metrics (also updated the release note).

[coffeepac]

/test pull-kubernetes-e2e-kops-aws
/test pull-kubernetes-local-e2e-containerized

[brancz]

/retest

[brancz]

I didn't realize that, let's give it another go then :) (I checked the logs on multiple runs, the failures seemed entirely disconnected)

[brancz]

/retest

[k8s-ci-robot]

@ehashman: The following test failed for commit 3539e89, say /retest to rerun them:

Test name	Details	Rerun command
pull-kubernetes-e2e-kops-aws	3539e89	link

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[brancz]

/retest

[dashpole]

/cc

[ehashman]

Now that tests seem fixed is this GTM?

[coffeepac]

@ehashman needs an 'approved' label. @derekwaynecarr is assigned but you can ping other people in the pkg/kubelet/OWNERS file

[brancz]

/lgtm

[danielqsj]

/lgtm

[derekwaynecarr]

thank you for the change.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/OWNERS [derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.