Allow users to use custom tags #83497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When discovering the kube version we only consider tags that match the glob 'v*'. By doing so users can create/use their custom tags as long as they don't look like a version (starting with a 'v'). We already do a similar thing when building the pause container, see how the `REV` is set in git.k8s.io/kubernetes/build/pause/Makefile.
k8s-ci-robot
added
release-note-none
|
/retest |
|
/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, hoegaarden The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justinsb
added a commit
to justinsb/etcdadm
that referenced
this pull request
Dec 16, 2020
Otherwise other tags confuse the version script. Equivalent to kubernetes/kubernetes#83497
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
When discovering the kube version we only consider tags that match the
glob 'v*'. By doing so users can create/use their custom tags as long as
they don't look like a version (starting with a 'v').
Which issue(s) this PR fixes:
-
Special notes for your reviewer:
We already do a similar thing when building the pause container, see how
the
REVis set in git.k8s.io/kubernetes/build/pause/Makefile.Does this PR introduce a user-facing change?: