Migrating Kubelet --enable-server and --provider-id flags to config #90494

knabben · 2020-04-25T23:41:16Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind cleanup
/area kubelet
/area kubelet-api

What this PR does / why we need it:
Moving Kubelet --enable-server and --provider-id to configuration file.

Which issue(s) this PR fixes:

Refs #86843

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

The Kubelet's `--enable-server` and `--provider-id` option is now available via the Kubelet config file field `enableServer` and `providerID` respectively.

k8s-ci-robot · 2020-04-25T23:41:25Z

Hi @knabben. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knabben · 2020-04-26T00:11:10Z

/assign @liggitt

fejta-bot · 2020-04-26T00:31:10Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

pkg/kubelet/apis/config/types.go

mtaufen · 2020-04-28T17:17:44Z

/ok-to-test
/priority important-longterm

knabben · 2020-05-01T16:52:38Z

/retest

liggitt · 2020-05-01T19:52:38Z

staging/src/k8s.io/kubelet/config/v1beta1/types.go

@@ -74,6 +74,9 @@ const (
 type KubeletConfiguration struct {
 	metav1.TypeMeta `json:",inline"`

+	// enableServer enables the Kubelet's server


clarify which server this enables (the secured port, I think). might also be worth mentioning that the readonly port is independently controlled.

mtaufen · 2020-05-12T17:19:34Z

staging/src/k8s.io/kubelet/config/v1beta1/types.go

+	// providerID, if set, sets the unique id of the instance that an external provider (i.e. cloudprovider)
+	// can use to identify a specific node.
+	// Dynamic Kubelet Config (beta): If dynamically updating this field, consider that changing
+	// the volumePluginDir may disrupt workloads relying on third party volume plugins.


Dynamic config comment needs to be updated to providerID

mtaufen · 2020-05-12T22:47:49Z

pkg/kubelet/apis/config/types.go

@@ -74,6 +74,9 @@ const (
 type KubeletConfiguration struct {
 	metav1.TypeMeta

+	// enableServer enables Kubelet's secured server. An insecure port is
+	// controlled by the readOnlyPort option.


Update this comment to match how we updated the comment on the external type:

// enableServer enables Kubelet's secured server. // Note: Kubelet's insecure port is controlled by the readOnlyPort option.

knabben · 2020-05-13T19:54:41Z

/retest

mtaufen · 2020-05-26T22:59:18Z

/lgtm

@liggitt for final review

liggitt · 2020-05-26T23:59:06Z

/approve

k8s-ci-robot · 2020-05-27T00:01:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kubelet/OWNERS~~ [liggitt]
~~pkg/kubelet/apis/config/OWNERS~~ [liggitt]
~~pkg/kubemark/OWNERS~~ [liggitt]
~~staging/src/k8s.io/kubelet/config/OWNERS~~ [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-05-27T01:04:55Z

@knabben: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kubernetes-e2e-kind	`8459c9b`	link	`/test pull-kubernetes-e2e-kind`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

knabben · 2020-05-27T02:12:19Z

/retest

kubernetes/kubernetes#90494

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2020

knabben force-pushed the kubelet-provider branch from 5b9c9bb to dff0051 Compare April 25, 2020 23:41

k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 25, 2020

k8s-ci-robot requested review from davidopp and krmayankk April 25, 2020 23:43

knabben force-pushed the kubelet-provider branch from dff0051 to 3035fc0 Compare April 25, 2020 23:57

k8s-ci-robot assigned liggitt Apr 26, 2020

knabben mentioned this pull request Apr 26, 2020

Migrate Kubelet flags to config #86843

Closed

30 tasks

liggitt reviewed Apr 27, 2020

View reviewed changes

pkg/kubelet/apis/config/types.go Show resolved Hide resolved

knabben force-pushed the kubelet-provider branch from 3035fc0 to 8ec8397 Compare May 1, 2020 02:55

liggitt reviewed May 1, 2020

View reviewed changes

mtaufen reviewed May 12, 2020

View reviewed changes

knabben force-pushed the kubelet-provider branch 3 times, most recently from e2386fd to 9ae8ccd Compare May 12, 2020 21:02

mtaufen reviewed May 12, 2020

View reviewed changes

knabben force-pushed the kubelet-provider branch from 9ae8ccd to eff211a Compare May 12, 2020 23:08

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2020

knabben force-pushed the kubelet-provider branch from eff211a to d3e48ff Compare May 16, 2020 22:12

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2020

knabben force-pushed the kubelet-provider branch 2 times, most recently from 99cb59c to 1408f07 Compare May 17, 2020 01:31

Moving enable-server and provider-id

8459c9b

knabben force-pushed the kubelet-provider branch from 1408f07 to 8459c9b Compare May 17, 2020 01:34

k8s-ci-robot assigned mtaufen May 26, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020

k8s-ci-robot merged commit 03cd30b into kubernetes:master May 27, 2020

k8s-ci-robot added this to the v1.19 milestone May 27, 2020

knabben deleted the kubelet-provider branch May 27, 2020 02:26

github-actions bot mentioned this pull request Jun 2, 2020

Week Ending May 31, 2020 dev-obs/actus#165

Open

rfranzke mentioned this pull request Aug 17, 2020

☂️-Issue for "Support for Kubernetes v1.19" gardener/gardener#2629

Closed

rfranzke added a commit to gardener/gardener-extension-provider-alicloud that referenced this pull request Sep 1, 2020

Add TODO note for new ways to put provider-id in kubelet config

dc447da

kubernetes/kubernetes#90494

rfranzke added a commit to gardener/gardener-extension-provider-alicloud that referenced this pull request Sep 3, 2020

Add TODO note for new ways to put provider-id in kubelet config

08fcf02

kubernetes/kubernetes#90494

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrating Kubelet --enable-server and --provider-id flags to config #90494

Migrating Kubelet --enable-server and --provider-id flags to config #90494

knabben commented Apr 25, 2020 •

edited

Loading

k8s-ci-robot commented Apr 25, 2020

knabben commented Apr 26, 2020

fejta-bot commented Apr 26, 2020

mtaufen commented Apr 28, 2020

knabben commented May 1, 2020

liggitt May 1, 2020

mtaufen May 12, 2020

mtaufen May 12, 2020

knabben commented May 13, 2020

mtaufen commented May 26, 2020

liggitt commented May 26, 2020

k8s-ci-robot commented May 27, 2020

k8s-ci-robot commented May 27, 2020

knabben commented May 27, 2020

Migrating Kubelet --enable-server and --provider-id flags to config #90494

Migrating Kubelet --enable-server and --provider-id flags to config #90494

Conversation

knabben commented Apr 25, 2020 • edited Loading

k8s-ci-robot commented Apr 25, 2020

knabben commented Apr 26, 2020

fejta-bot commented Apr 26, 2020

mtaufen commented Apr 28, 2020

knabben commented May 1, 2020

liggitt May 1, 2020

Choose a reason for hiding this comment

mtaufen May 12, 2020

Choose a reason for hiding this comment

mtaufen May 12, 2020

Choose a reason for hiding this comment

knabben commented May 13, 2020

mtaufen commented May 26, 2020

liggitt commented May 26, 2020

k8s-ci-robot commented May 27, 2020

k8s-ci-robot commented May 27, 2020

knabben commented May 27, 2020

knabben commented Apr 25, 2020 •

edited

Loading