Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xhyve suggests obsolete WantShowDriverDeprecationNotification setting #4161

Closed
ahmetb opened this issue Apr 25, 2019 · 2 comments · Fixed by #4431
Closed

xhyve suggests obsolete WantShowDriverDeprecationNotification setting #4161

ahmetb opened this issue Apr 25, 2019 · 2 comments · Fixed by #4431
Labels
co/xhyve good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2

Comments

@ahmetb
Copy link
Member

ahmetb commented Apr 25, 2019

minikube v1.0.0

I use minikube start --vm-driver xhyve

which tells me

⚠️  The xhyve driver is deprecated and support for it will be removed in a future release.
Please consider switching to the hyperkit driver, which is intended to replace the xhyve driver.
See https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#hyperkit-driver for more information.
To disable this message, run [minikube config set WantShowDriverDeprecationNotification false]

but

$ minikube config set WantShowDriverDeprecationNotification false

💣  Set failed: Property name WantShowDriverDeprecationNotification not found
@tstromberg
Copy link
Contributor

Good catch. It seems this knob was removed some time ago. We should have also removed xhyve support for v1.0.0 but failed to do so.

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 25, 2019
@tstromberg tstromberg changed the title "config set" failed: Property name WantShowDriverDeprecationNotification not found xhyve suggests obsolete WantShowDriverDeprecationNotification setting Apr 25, 2019
@tstromberg tstromberg added this to the v1.1.0-candidate milestone Apr 25, 2019
@tstromberg tstromberg removed this from the v1.1.0-candidate milestone May 1, 2019
@tstromberg tstromberg added r/2019q2 Issue was last reviewed 2019q2 priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 24, 2019
@Pradip-Khakurel Pradip-Khakurel mentioned this issue Jun 5, 2019
Merged
@Pradip-Khakurel
Copy link
Contributor

Hey, I tried to solve this tell me if it is ok : ). Many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
co/xhyve good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. r/2019q2 Issue was last reviewed 2019q2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix ShowDriverDeprecationNotification config setting Pradip-Khakurel/minikube
3 participants
@tstromberg @ahmetb @Pradip-Khakurel