-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ShowDriverDeprecationNotification config setting #4431
fix ShowDriverDeprecationNotification config setting #4431
Conversation
Welcome @Pradip-Khakurel! |
Hi @Pradip-Khakurel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Pradip-Khakurel If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xhyve driver was already removed. I believe this fix is not cover the full story, but just the error output of "Property name WantShowDriverDeprecationNotification not found"
/ok-to-test |
@fenglixa : removing the deprecated drivers is a different topic |
LGTM. We'll merge this once tests pass. |
fix #4161:
WantShowDriverDeprecationNotification property seems like a mistype in the console message. The real setting is ShowDriverDeprecationNotification but it needs to be added in the list of configurable settings (the variable settings in config.go). I could have renamed everything to WantShowDriverDeprecationNotification but it seems easier and still very readable that way.
User test: