Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver=none 'CHANGE_MINIKUBE_NONE_USER' regression in v1.3.0 #5014

Closed
arm4b opened this issue Aug 7, 2019 · 0 comments · Fixed by #5023
Closed

Driver=none 'CHANGE_MINIKUBE_NONE_USER' regression in v1.3.0 #5014

arm4b opened this issue Aug 7, 2019 · 0 comments · Fixed by #5023
Assignees
Labels
co/none-driver kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@arm4b
Copy link

arm4b commented Aug 7, 2019

Problem
Regression in recent minikube v1.3.0 when CHANGE_MINIKUBE_NONE_USER=true stopped to work properly.
It's expected to set .minikube dir ownership to the user running sudo when vmdriver=none (per CI testing example), however root is used.

Most probably regression introduced in #4737 and so chown is not executed as a last step when cluster is started.

The exact command to reproduce the issue:

$ whoami
circleci

$ CHANGE_MINIKUBE_NONE_USER=true sudo -E minikube-1.3.0 start --vm-driver=none

Unexpected files ownership (root):

$ sudo ls -la ~/.minikube/
total 80
drwxr-xr-x 10 root     root     4096 Aug  7 22:47 .
drwxr-xr-x 19 circleci circleci 4096 Aug  7 22:48 ..
drwxr-xr-x  2 root     root     4096 Aug  7 22:47 addons
-rw-r--r--  1 root     root     1298 Aug  7 22:47 apiserver.crt
-rw-------  1 root     root     1679 Aug  7 22:47 apiserver.key
drwxr-xr-x  4 root     root     4096 Aug  7 22:47 cache
-rw-r--r--  1 root     root     1066 Aug  7 22:47 ca.crt
-rw-------  1 root     root     1675 Aug  7 22:47 ca.key
drwxr-xr-x  2 root     root     4096 Aug  7 22:47 certs
-rw-r--r--  1 root     root     1103 Aug  7 22:47 client.crt
-rw-------  1 root     root     1679 Aug  7 22:47 client.key
drwxr-xr-x  2 root     root     4096 Aug  7 22:47 config
drwxr-xr-x  2 root     root     4096 Aug  7 22:47 files
drwxr-xr-x  2 root     root     4096 Aug  7 22:47 logs
drwxr-xr-x  3 root     root     4096 Aug  7 22:47 machines
drwx------  3 root     root     4096 Aug  7 22:47 profiles
-rw-r--r--  1 root     root     1074 Aug  7 22:47 proxy-client-ca.crt
-rw-------  1 root     root     1679 Aug  7 22:47 proxy-client-ca.key
-rw-r--r--  1 root     root     1103 Aug  7 22:47 proxy-client.crt
-rw-------  1 root     root     1679 Aug  7 22:47 proxy-client.key

Comparing to minikube 1.2.0 with correct files ownership:

$ whoami
circleci

$ CHANGE_MINIKUBE_NONE_USER=true sudo -E minikube-1.2.0 start --vm-driver=none
$ sudo ls -la ~/.minikube/
total 84
drwxr-xr-x 10 circleci circleci 4096 Aug  7 23:00 .
drwxr-xr-x 19 circleci circleci 4096 Aug  7 23:00 ..
drwxr-xr-x  2 circleci circleci 4096 Aug  7 23:00 addons
-rw-r--r--  1 circleci circleci 1298 Aug  7 23:00 apiserver.crt
-rw-------  1 circleci circleci 1675 Aug  7 23:00 apiserver.key
drwxr-xr-x  4 circleci circleci 4096 Aug  7 23:00 cache
-rw-r--r--  1 circleci circleci 1066 Aug  7 23:00 ca.crt
-rw-------  1 circleci circleci 1679 Aug  7 23:00 ca.key
drwxr-xr-x  2 circleci circleci 4096 Aug  7 23:00 certs
-rw-r--r--  1 circleci circleci 1103 Aug  7 23:00 client.crt
-rw-------  1 circleci circleci 1675 Aug  7 23:00 client.key
drwxr-xr-x  2 circleci circleci 4096 Aug  7 23:00 config
drwxr-xr-x  2 circleci circleci 4096 Aug  7 23:00 files
-rw-r--r--  1 circleci circleci   29 Aug  7 23:00 last_update_check
drwxr-xr-x  2 circleci circleci 4096 Aug  7 23:00 logs
drwxr-xr-x  3 circleci circleci 4096 Aug  7 23:00 machines
drwx------  3 circleci circleci 4096 Aug  7 23:00 profiles
-rw-r--r--  1 circleci circleci 1074 Aug  7 23:00 proxy-client-ca.crt
-rw-------  1 circleci circleci 1675 Aug  7 23:00 proxy-client-ca.key
-rw-r--r--  1 circleci circleci 1103 Aug  7 23:00 proxy-client.crt
-rw-------  1 circleci circleci 1675 Aug  7 23:00 proxy-client.key

The operating system version:
Ubuntu 16.04.5 LTS

@afbjorklund afbjorklund added co/none-driver kind/bug Categorizes issue or PR as related to a bug. labels Aug 8, 2019
@afbjorklund afbjorklund added this to the v1.3.1 milestone Aug 8, 2019
arm4b pushed a commit to StackStorm/stackstorm-k8s that referenced this issue Aug 8, 2019
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/none-driver kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants