Upgrade to Docker 17.06-ce #1542
Conversation
This is an attempt to address kubernetes#1518. It does actually fix kubernetes#1518, but breaks much of Kubernetes. :) Don't merge this, I'm just creating a PR that people can play with if they're interested in taking it further.
k8s-ci-robot
added
the
cncf-cla: yes
|
Can one of the admins verify this patch? |
|
One reason it doesn't work: kubernetes/kubernetes#40182. There are probably others. |
Codecov Report
@@ Coverage Diff @@
## master #1542 +/- ##
=========================================
- Coverage 28.92% 28.9% -0.02%
=========================================
Files 81 81
Lines 5311 5311
=========================================
- Hits 1536 1535 -1
- Misses 3582 3583 +1
Partials 193 193
Continue to review full report at Codecov.
|
|
@minikube-bot ok to test Just to make sure our tests catch the failures :) |
|
Jenkins put the ISO URL at https://storage.googleapis.com/minikube-builds/1542/minikube-testing.iso if anybody wants to try this without compiling it. |
|
It's actually working fairly well for me now. |
|
@bryanlarsen any updates on this one? |
|
We're not going to be able to take this until Kubernetes upstream is tested and verified against Docker 17.05. The current highest is 1.12.6: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG.md#external-dependency-version-information |
|
If you are stuck with this, you can preview the custom ISO with: Works perfectly for me! 🍻 |
|
I've upgraded this PR to use 17.06-ce rather than 17.05-ce since that's long term stable. I also merged in master to get Kube 1.7. Unfortunately, this now requires using a new minikube executable as well as using a new ISO. Does Jenkins stash the minikube executable somewhere convenient for others to access, in a manner similar to how it stashes the iso at https://storage.googleapis.com/minikube-builds/1542/? |
Yeah all the exe's should be in that same location: $ gsutil ls gs://minikube-builds/1542/
gs://minikube-builds/1542/build_iso.sh
gs://minikube-builds/1542/common.sh
gs://minikube-builds/1542/e2e-darwin-amd64
gs://minikube-builds/1542/e2e-linux-amd64
gs://minikube-builds/1542/e2e-windows-amd64.exe
gs://minikube-builds/1542/linux_integration_tests_kvm.sh
gs://minikube-builds/1542/linux_integration_tests_kvm_alt.sh
gs://minikube-builds/1542/linux_integration_tests_none.sh
gs://minikube-builds/1542/linux_integration_tests_virtualbox.sh
gs://minikube-builds/1542/localkube
gs://minikube-builds/1542/minikube-darwin-amd64
gs://minikube-builds/1542/minikube-linux-amd64
gs://minikube-builds/1542/minikube-testing.iso
gs://minikube-builds/1542/minikube-testing.iso.sha256
gs://minikube-builds/1542/minikube-windows-amd64.exe
gs://minikube-builds/1542/minikube.iso
gs://minikube-builds/1542/minikube.iso.sha256
gs://minikube-builds/1542/minikube_cross_build_and_upload.sh
gs://minikube-builds/1542/minikube_set_pending.sh
gs://minikube-builds/1542/osx_integration_tests_virtualbox.sh
gs://minikube-builds/1542/osx_integration_tests_xhyve.sh
gs://minikube-builds/1542/print-debug-info.sh
gs://minikube-builds/1542/release_build_and_upload.sh
gs://minikube-builds/1542/release_github_page.sh
gs://minikube-builds/1542/release_update_installers.sh
gs://minikube-builds/1542/release_update_releases_json.sh
gs://minikube-builds/1542/windows_integration_test_hyperv.ps1
gs://minikube-builds/1542/testdata/ |
see kubernetes/minikube#1542 this isn't working.
|
Hi - any updates on this issue? We need to run docker multistage and kind of stuck at the moment. |
|
We don't use this PR any more. What we do is we create a VM manually, install the docker 17.06 and then install minikube with --vm-driver=None |
|
Thanks for the prompt reply Brian!
I am not sure how to make this work?I have tried using the custom iso and
minikube listed on the PR but
running into errors on minikube starts.
I am trying out a multistage build on OSX using xhyve. Not sure how to
update docker on this vm. Any suggestions?
…On Wed, Sep 20, 2017 at 1:31 PM, Bryan Larsen ***@***.***> wrote:
We don't use this PR any more. What we do is we create a VM manually,
install the docker 17.06 and then install minikube with --vm-driver=None
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1542 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAP3NnsfKHB2dDH56U-8OJ0VL_iGLkGks5skWf6gaJpZM4Nrnpb>
.
|
this ISO doesn't work for me because of ExecStart string in /usr/lib/systemd/system/docker.service. It tries to run "docker daemon" command, but it needs to use dockerd instead. |
|
any plan to support multistage build in minikube anytime soon ? does anyone know? |
|
Once we get k8s 1.8 merged we should be able to upgrade Docker. Old versions of k8s did not support the versions of docker that have multi-stage builds. |
|
@dlorenc thanks do you have the link for the PR so I can watch it ? |
k8s-ci-robot
added
the
size/S
|
Hope you don't mind but I resolved the merge conflicts since they were basically a no-op. I would like to get this merged soon now that we are on 1.8 |
|
At this point, why not use 17.09? |
|
@centromere we only like to use the versions that are official vetted by k8s. I don't think 17.09 is fully tested against 1.8 clusters yet. However, it might be useful to expose some functionality to fetch arbitrary docker versions. |
This is an attempt to address #1518. It does actually fix #1518, but breaks much of Kubernetes. :) Don't merge this, I'm just creating a PR that people can play with if they're interested in taking it further.