-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ipset (hash:ip and list:set) #1697
Conversation
Weave Net, a container networking solution, requires the `xt_set` module in order to function properly. Minikube's Linux image currently does not have it, making Weave Net fail with errors like: - `modprobe: FATAL: Module xt_set not found in directory /lib/modules/4.9.13` - `FATA: ipset [create weave-local-pods hash:ip] failed: ipset v6.29: Kernel error received: set type not supported: exit status 1` This changes addresses such issues.
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1697 +/- ##
======================================
Coverage 38.7% 38.7%
======================================
Files 51 51
Lines 2664 2664
======================================
Hits 1031 1031
Misses 1453 1453
Partials 180 180 Continue to review full report at Codecov.
|
@minikube-bot ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
As mentioned by @r2d4 on Slack, and in case someone faces the same issue with
|
This issue still persists. Please reopen. The ISO containing the fix is also bugged as it does not include the ipset module. |
I concur. Please reopen. The ISO does not contain ipset or xt_set modules. |
This is a PR so we can't just reopen it, is there an issue tracking the missing modules? Could you open one if not? |
Weave Net requires the
xt_set
module to function properly.Minikube's Linux image currently does not have it, making Weave Net fail with errors like:
modprobe: FATAL: Module xt_set not found in directory /lib/modules/4.9.13
FATA: ipset [create weave-local-pods hash:ip] failed: ipset v6.29: Kernel error received: set type not supported: exit status 1
This changes addresses such issues and fixes weaveworks/weave/issues/3062.