Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore mount command and unswap port and mountVersion #1717

Merged
merged 2 commits into from
Jul 20, 2017

Conversation

q3aiml
Copy link
Contributor

@q3aiml q3aiml commented Jul 20, 2017

@aaron-prindle this seems to have been a mistake in 6f42d58 (#1705)?

This seems to have been a mistake in 6f42d58.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 20, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Jul 20, 2017

Codecov Report

Merging #1717 into master will increase coverage by 0.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   35.93%   35.94%   +0.01%     
==========================================
  Files          51       51              
  Lines        3337     3338       +1     
==========================================
+ Hits         1199     1200       +1     
  Misses       1958     1958              
  Partials      180      180
Impacted Files Coverage Δ
pkg/minikube/cluster/cluster.go 41.12% <0%> (ø) ⬆️
cmd/minikube/cmd/mount.go 8.24% <100%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8ef22...1f1076d. Read the comment docs.

Seeing since 6f42d58:

sudo mount -t 9p -o trans=tcp,port=9p2000.u,dfltuid=1001,dfltgid=1001,version=32777,msize=262144 192.168.42.1 /opt/host-persist;
sudo chmod 775 /opt/host-persist;
SSH cmd err, output: <nil>: mount: wrong fs type, bad option, bad superblock on 192.168.42.1,
@dlorenc
Copy link
Contributor

dlorenc commented Jul 20, 2017

@minikube-bot ok to test

@q3aiml
Copy link
Contributor Author

q3aiml commented Jul 20, 2017

I'm running into one other issue after 6f42d58 where it seems the port and version are swapped:

sudo mount -t 9p -o trans=tcp,port=9p2000.u,dfltuid=1001,dfltgid=1001,version=32777,msize=262144 192.168.42.1 /opt/host-persist;
    sudo chmod 775 /opt/host-persist;
    SSH cmd err, output: <nil>: mount: wrong fs type, bad option, bad superblock on 192.168.42.1,

Let me know if it is better to add that change here or open a separate PR.

@aaron-prindle
Copy link
Contributor

@q3aiml Thanks for catching this! If you can put the port/version change in this PR that would be great, thanks!

@q3aiml q3aiml changed the title Restore mount command Restore mount command and unswap port and mountVersion Jul 20, 2017
@q3aiml
Copy link
Contributor Author

q3aiml commented Jul 20, 2017

Sure thing! Thank you for digging into the 9p issues. It's the best after hitting an issue to go and find that not only do others see it too (I'm not alone!) but then there is also a patch

@aaron-prindle aaron-prindle merged commit c98ac20 into kubernetes:master Jul 20, 2017
@q3aiml q3aiml deleted the restore-mount-cmd branch July 20, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants