-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore mount command and unswap port and mountVersion #1717
Conversation
This seems to have been a mistake in 6f42d58.
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1717 +/- ##
==========================================
+ Coverage 35.93% 35.94% +0.01%
==========================================
Files 51 51
Lines 3337 3338 +1
==========================================
+ Hits 1199 1200 +1
Misses 1958 1958
Partials 180 180
Continue to review full report at Codecov.
|
Seeing since 6f42d58: sudo mount -t 9p -o trans=tcp,port=9p2000.u,dfltuid=1001,dfltgid=1001,version=32777,msize=262144 192.168.42.1 /opt/host-persist; sudo chmod 775 /opt/host-persist; SSH cmd err, output: <nil>: mount: wrong fs type, bad option, bad superblock on 192.168.42.1,
@minikube-bot ok to test |
I'm running into one other issue after 6f42d58 where it seems the port and version are swapped:
Let me know if it is better to add that change here or open a separate PR. |
@q3aiml Thanks for catching this! If you can put the port/version change in this PR that would be great, thanks! |
Sure thing! Thank you for digging into the 9p issues. It's the best after hitting an issue to go and find that not only do others see it too (I'm not alone!) but then there is also a patch |
@aaron-prindle this seems to have been a mistake in 6f42d58 (#1705)?