Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAKD - Kubernetes Dashboard addon #17775

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

manusa
Copy link
Contributor

@manusa manusa commented Dec 12, 2023

This PR adds an addon for automatically setting up YAKD (Yet Another Kubernetes Dashboard).

This is an alternative Kubernetes Dashboard with special support for Minikube, OpenShift, and other flavors of Kubernetes.

It was originally started as an example project for YAKC (Yet Another Kubernetes Client) but it was recently spun off as a separate project.

Regarding Minikube, it offers specific functionality such as cluster detection, support for opening NodePort services from the interface, and more.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @manusa!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @manusa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2023
@manusa manusa mentioned this pull request Dec 12, 2023
Add an addon for automatically setting up [YAKD (Yet Another Kubernetes Dashboard)](https://github.com/manusa/yakd)

This is an alternative Kubernetes Dashboard with special support for Minikube, OpenShift, and other flavors of Kubernetes.

It was originally started as an example project for [YAKC (Yet Another Kubernetes Client)](https://github.com/manusa/yakc) but it was recently spun off as a separate project.

Regarding Minikube, it offers specific functionality such as cluster detection, support for opening NodePort services from the interface, and more.
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you're only building your image for amd64, would it be possible to also build it for arm64?

pkg/addons/addons.go Outdated Show resolved Hide resolved
test/integration/addons_test.go Outdated Show resolved Hide resolved
@manusa
Copy link
Contributor Author

manusa commented Dec 13, 2023

Hey Steven,
Thanks for the review.
I've implemented the changes you requested.
I have also updated the image reference to a newer version that has images for amd64 and arm64.
Let me know if there's anything else you need or if I should squash the commits.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2023
@minikube-pr-bot

This comment has been minimized.

@minikube-pr-bot

This comment has been minimized.

Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then typo this it looks good

minikube service yakd-dashboard -n yakd-dashboard
```

There dashboard will open in a new browser window and you should be able to start using it with no further hassle.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There dashboard will open in a new browser window and you should be able to start using it with no further hassle.
The dashboard will open in a new browser window and you should be able to start using it with no further hassle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thx!

Co-authored-by: Steven Powell <[email protected]>
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@spowelljr spowelljr merged commit ed91699 into kubernetes:master Dec 20, 2023
7 of 24 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manusa, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17775) |
+----------------+----------+---------------------+
| minikube start | 50.7s    | 50.1s               |
| enable ingress | 26.6s    | 25.9s               |
+----------------+----------+---------------------+

Times for minikube ingress: 27.6s 23.6s 27.1s 27.1s 27.5s
Times for minikube (PR 17775) ingress: 27.6s 27.1s 23.7s 23.7s 27.6s

Times for minikube start: 52.1s 51.1s 50.9s 50.6s 49.0s
Times for minikube (PR 17775) start: 51.8s 49.8s 51.7s 49.8s 47.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17775) |
+----------------+----------+---------------------+
| minikube start | 25.0s    | 22.9s               |
| enable ingress | 19.9s    | 19.8s               |
+----------------+----------+---------------------+

Times for minikube (PR 17775) start: 24.6s 24.8s 21.6s 21.2s 22.4s
Times for minikube start: 23.9s 24.8s 25.3s 25.8s 25.1s

Times for minikube ingress: 20.8s 17.9s 20.8s 19.4s 20.8s
Times for minikube (PR 17775) ingress: 19.8s 18.8s 20.8s 20.8s 18.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 17775) |
+----------------+----------+---------------------+
| minikube start | 21.7s    | 23.0s               |
| enable ingress | 34.3s    | 31.3s               |
+----------------+----------+---------------------+

Times for minikube start: 20.2s 20.8s 23.3s 21.5s 22.7s
Times for minikube (PR 17775) start: 23.4s 24.0s 23.8s 23.8s 20.1s

Times for minikube ingress: 31.3s 46.3s 31.3s 31.3s 31.3s
Times for minikube (PR 17775) ingress: 31.3s 30.3s 31.3s 32.3s 31.3s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Hyperkit_macOS TestFunctional/parallel/CertSync (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/CpCmd (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/DashboardCmd (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/FileSync (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/MySQL (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/NodeLabels (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmdConnect (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/SSHCmd (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/StatusCmd (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh) 0.71 (chart)
Hyperkit_macOS TestFunctional/parallel/TunnelCmd/serial/DNSResolutionByDig (gopogh) 0.71 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@manusa manusa deleted the feat/addons-yakd branch December 21, 2023 05:43
@medyagh medyagh mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants