Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.12 #18585

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Kicbase/ISO: Update cri-dockerd from v0.3.3 to v0.3.12 #18585

merged 3 commits into from
Apr 8, 2024

Conversation

minikube-bot
Copy link
Collaborator

The cri-dockerd project released a new version

This PR was auto-generated by make update-cri-dockerd-version using update-cri-dockerd-version.yml CI Workflow.

A minikube maintainer needs to checkout this PR, run make build-and-upload-cri-dockerd-binaries, and then comment ok-to-build-image.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2024
@medyagh
Copy link
Member

medyagh commented Apr 5, 2024

ok-to-build-image

@medyagh
Copy link
Member

medyagh commented Apr 5, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2024
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

ok-to-build-iso

@minikube-bot minikube-bot force-pushed the auto_bump_cri_dockerd_version branch from 48f9a16 to bf53bb3 Compare April 8, 2024 10:04
@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

ok-to-build-image

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-bot
Copy link
Collaborator Author

Hi @minikube-bot, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18585) |
+----------------+----------+---------------------+
| minikube start | 54.0s    | 52.8s               |
| enable ingress | 26.8s    | 26.2s               |
+----------------+----------+---------------------+

Times for minikube start: 55.7s 54.5s 53.7s 52.8s 53.4s
Times for minikube (PR 18585) start: 54.2s 50.3s 50.9s 55.5s 53.1s

Times for minikube ingress: 27.6s 23.5s 27.1s 28.0s 27.7s
Times for minikube (PR 18585) ingress: 23.6s 28.5s 23.5s 27.6s 27.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18585) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 23.3s               |
| enable ingress | 21.3s    | 21.4s               |
+----------------+----------+---------------------+

Times for minikube start: 24.3s 23.9s 23.5s 21.7s 23.9s
Times for minikube (PR 18585) start: 24.9s 23.8s 22.6s 24.7s 20.4s

Times for minikube ingress: 21.2s 21.3s 21.3s 21.3s 21.3s
Times for minikube (PR 18585) ingress: 22.3s 21.3s 21.3s 21.3s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18585) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 22.0s               |
| enable ingress | 35.1s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.1s 23.1s 20.4s 22.9s
Times for minikube (PR 18585) start: 22.5s 23.0s 23.5s 20.2s 21.0s

Times for minikube ingress: 31.7s 31.7s 32.8s 47.8s 31.8s
Times for minikube (PR 18585) ingress: 19.8s 31.8s 31.7s 31.8s 30.8s

@minikube-pr-bot

This comment has been minimized.

Sign in to view
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Windows TestDownloadOnly/v1.30.0-rc.1/json-events (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.30.0-rc.1/kubectl (gopogh) n/a
Docker_Windows TestDownloadOnly/v1.30.0-rc.1/preload-exists (gopogh) n/a
Docker_Linux_containerd TestAddons/parallel/CSI (gopogh) 0.00 (chart)
KVM_Linux_containerd TestAddons/parallel/CSI (gopogh) 0.61 (chart)
Docker_Linux_containerd_arm64 TestScheduledStopUnix (gopogh) 1.19 (chart)
QEMU_macOS TestFunctional/parallel/CertSync (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/CpCmd (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/DashboardCmd (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/DockerEnv/bash (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/FileSync (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageBuild (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListJson (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListShort (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListTable (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageListYaml (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/NodeLabels (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/PersistentVolumeClaim (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/DeployApp (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/Format (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/HTTPS (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/JSONOutput (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/List (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/ServiceCmd/URL (gopogh) 8.14 (chart)
QEMU_macOS TestFunctional/parallel/SSHCmd (gopogh) 8.14 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: minikube-bot, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit f17e74e into kubernetes:master Apr 8, 2024
21 of 38 checks passed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@minikube-bot @k8s-ci-robot @medyagh @minikube-pr-bot @spowelljr