-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for ingress addon #2254
Conversation
Can one of the admins verify this patch? |
@minikube-bot ok to test |
@r2d4 I have fixed the failed issue, now tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is much appreciated.
minikubeRunner := NewMinikubeRunner(t) | ||
kubectlRunner := util.NewKubectlRunner(t) | ||
|
||
minikubeRunner.RunCommand("addons enable ingress", true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future work, we should utilize the minikube cache
command to make sure that the ingress controller image is cached for our tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@r2d4 Okay, I'll make this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this feature from #2273 .
The commit added test codes for Ingress addon, the feature request from #2174. This test will create a ingress binding
nginx.example.com
domain name, and resolve to nginx service, finally use HTTP request to check response content.For test result as below:
/cc @r2d4