Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support containerd #3040

Merged
merged 3 commits into from
Aug 21, 2018
Merged

support containerd #3040

merged 3 commits into from
Aug 21, 2018

Conversation

yanxuean
Copy link
Contributor

@yanxuean yanxuean commented Aug 2, 2018

Signed-off-by: yanxuean [email protected]

Waiting for a containerd release version with supporting no-pivot.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanxuean
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: r2d4

If they are not already assigned, you can assign the PR to them by writing /assign @r2d4 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 2, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@yanxuean
Copy link
Contributor Author

yanxuean commented Aug 2, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2018
@yanxuean yanxuean mentioned this pull request Aug 2, 2018
Closed
@Random-Liu Random-Liu mentioned this pull request Aug 9, 2018
Merged
@yanxuean yanxuean force-pushed the minikube-rel8.2 branch 2 times, most recently from eef67b9 to 0057cda Compare August 16, 2018 11:43
@yanxuean yanxuean changed the title [WIP]support containerd support containerd Aug 17, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2018
@yanxuean
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2018
@yanxuean
Copy link
Contributor Author

/assign @r2d4 @Random-Liu

@yanxuean
Copy link
Contributor Author

/cc @crosbymichael @dmcgowan @stevvooe

@k8s-ci-robot
Copy link
Contributor

@yanxuean: GitHub didn't allow me to request PR reviews from the following users: crosbymichael, dmcgowan, stevvooe.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @crosbymichael @dmcgowan @stevvooe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crosbymichael
Copy link

looks good

@dlorenc
Copy link
Contributor

dlorenc commented Aug 20, 2018

@minikube-bot OK to test

@yanxuean
Copy link
Contributor Author

@minikube-bot OK to test

@yanxuean
Copy link
Contributor Author

yanxuean commented Aug 21, 2018 •
edited
Loading

@dlorenc thanks
Have the CI some bug? I have not found the error info which is related to containerd:)
Any suggestion? How should I debug it?

@dlorenc dlorenc merged commit 1971dc9 into kubernetes:master Aug 21, 2018
@yanxuean
Copy link
Contributor Author

@dlorenc thanks

@yanxuean yanxuean deleted the minikube-rel8.2 branch August 22, 2018 00:45
@yanxuean yanxuean mentioned this pull request Aug 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc approved these changes

Assignees

@r2d4 r2d4

@Random-Liu Random-Liu

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@yanxuean @k8s-ci-robot @minikube-bot @crosbymichael @dlorenc @r2d4 @Random-Liu