Stop docker daemon, when running cri-o #3211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minikube.iso starts every runtime, by default
Might be running an alternative container runtime
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: afbjorklund If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
|
Note that cri-o will fail to
|
balopat
approved these changes
Nov 15, 2018
| fmt.Println("Stopping extra container runtimes...") | ||
|
|
||
| containerRuntime := viper.GetString(containerRuntime) | ||
| if config.VMDriver != "none" && containerRuntime != "" { |
There was a problem hiding this comment.
nit: can we combine the `config.VMDriver != "none" ifs into one?
priyawadhwa
pushed a commit
to priyawadhwa/minikube
that referenced
this pull request
Nov 15, 2018
After stopping any runtimes that aren't being used, if we're using containerd then we need to restart it. This is because it competes with cri-o to listen on port 10010, causing a necesary plugin to not be installed. After stopping cri-o, we need to restart containerd so that the plugin is installed. I also added some preflight checks when using alternative runtimes. kubeadm checks to make sure the Docker service is running, so I disabled that. It also checks if a few ports are available; these are ports that containerd uses, so I also added them to the ignore list. This should finish the work started in kubernetes#3211, which stopped alternative runtimes but didn't restart containerd. I was able to run "minikube start" with containerd locally with this change.
priyawadhwa
pushed a commit
to priyawadhwa/minikube
that referenced
this pull request
Nov 15, 2018
After stopping any runtimes that aren't being used, if we're using containerd then we need to restart it. This is because it competes with cri-o to listen on port 10010, causing a necesary plugin to not be installed. After stopping cri-o, we need to restart containerd so that the plugin is installed. I also added some preflight checks when using alternative runtimes. kubeadm checks to make sure the Docker service is running, so I disabled that. It also checks if a few ports are available; these are ports that containerd uses, so I also added them to the ignore list. This should finish the work started in kubernetes#3211, which stopped alternative runtimes but didn't restart containerd. I was able to run "minikube start" with containerd locally with this change.
balopat
pushed a commit
that referenced
this pull request
Nov 16, 2018
After stopping any runtimes that aren't being used, if we're using containerd then we need to restart it. This is because it competes with cri-o to listen on port 10010, causing a necesary plugin to not be installed. After stopping cri-o, we need to restart containerd so that the plugin is installed. I also added some preflight checks when using alternative runtimes. kubeadm checks to make sure the Docker service is running, so I disabled that. It also checks if a few ports are available; these are ports that containerd uses, so I also added them to the ignore list. This should finish the work started in #3211, which stopped alternative runtimes but didn't restart containerd. I was able to run "minikube start" with containerd locally with this change.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop the docker daemon, when running an alternative container runtime (and vice-versa)
Remove the output from docker-env, since there is nothing responding on port 2376 anyway
Cannot connect to the Docker daemon at tcp://*:2376. Is the docker daemon running?But as long as we are using docker machine, it will always be started (by the provisioner)
Closes #3068