Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DefaultMountVersion to 9p2000.L #3796

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

kron4eg
Copy link
Contributor

@kron4eg kron4eg commented Mar 5, 2019

9p2000.u is a legacy protocol version. This upgrades us to the most recent version with better permissions handling. From the Linux kernel docs: https://landley.net/kdocs/Documentation/filesystems/9p.txt

Around 2003 Plan 9 was open sourced, which led to the development of an
extended version of the protocol, "9p2000.U" (for Unix) providing full posix
semantics .... The current protocol version, "9p2000.L" (for Linux) was developed for v9fs
after a few years of real world experience. It tailors the protocol to Linux
with support for ACLs, file locking, more efficient directory listing, corner
cases in things like file deletion, and so on. 

Fixes #2290

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 5, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kron4eg
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

If they are not already assigned, you can assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 5, 2019
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

I think this PR is a great idea. Thanks for proposing it! Will approve once I can see that the integration tests pass.

@afbjorklund
Copy link
Collaborator

Looks OK, but I think we need to also upgrade the server for it to be of most use ?

@kron4eg
Copy link
Contributor Author

kron4eg commented Mar 6, 2019

@afbjorklund I'm not sure I got you. Do you mean third_party/go9p library?

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

FWIW, I think updating the server is unrelated to this version change. L has been around for a very long time.

@afbjorklund
Copy link
Collaborator

@kron4eg yes, I think that is serving ?

@afbjorklund
Copy link
Collaborator

Afaik, it will negotiate. So we should start with updating this client, but also update server

@kron4eg
Copy link
Contributor Author

kron4eg commented Mar 6, 2019

Unfortunately I can't find from where third_party/go9p originated. But it worked with old minikube releases (oldest tested is from 2 years ago) when I've explicitly specified --9p-version=9p2000.L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants