-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add solution catalog to help users who run into known problems #3931
Add solution catalog to help users who run into known problems #3931
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! This should hopefully cut down on the amount on "VM lost" and "Corporate proxy" issues ?
pkg/minikube/problem/err_map.go
Outdated
import "regexp" | ||
|
||
// r is a shortcut around regexp.MustCompile | ||
func r(s string) *regexp.Regexp { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe call this "re()", or perhaps that is just me mixing it with r''
raw strings (from python...)
This extracts the nascent problem detection code from exit.go, and formalizes it in into a package that we can use for the upcoming network preflights (#3145).
Example output:
This also renames exit.WithProblems to exit.WithLogEntries to avoid the terminology mismatch.