Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: Add config for tc u32 filter and mirred action #4340

Merged
merged 1 commit into from
May 24, 2019

Conversation

amshinde
Copy link
Contributor

These are needed for running Kata Containers in minikube.
Kata uses linux tc for its networking

Signed-off-by: Archana Shinde [email protected]

These are needed for running Kata Containers in minikube.
Kata uses linux tc for its networking

Signed-off-by: Archana Shinde <[email protected]>
@k8s-ci-robot
Copy link
Contributor

Welcome @amshinde!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @amshinde. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amshinde
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sharifelgamal

If they are not already assigned, you can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

Thank you! The test failure is an unrelated flake.

@tstromberg
Copy link
Contributor

@minikube-bot ok to test

@tstromberg
Copy link
Contributor

As a side note, I am really excited about the possibility of running Kata containers in minikube. Please let me know if there is anything else I can do to help.

@grahamwhaley
Copy link

Hi @tstromberg - sure - the original issue turned up as I was documenting how to install/run kata under minikube: kata-containers/documentation#445

So, what would it take to get Kata as a supported option in minikube, like I think I have seen gvisor is ? If we can work together on that, that would be great :-)

@tstromberg
Copy link
Contributor

tstromberg commented May 24, 2019

Hi @tstromberg - sure - the original issue turned up as I was documenting how to install/run kata under minikube: kata-containers/documentation#445

So, what would it take to get Kata as a supported option in minikube, like I think I have seen gvisor is ? If we can work together on that, that would be great :-)

You know, I'm not actually sure what it will take, but I'm happy to help point you in the right direction. When the maintainers came up with the minikube development roadmap for 2019, we identified that we wanted support for Kata containers, but no one has yet stepped up to look into it. I think Kata Containers have a great design and would personally love to see support for it. I've now opened an issue
to track changes and discussion for it: #4347

I agree that following the gvisor addon is a good approach, but if for some reason it's too complicated to include as an addon, I'm happy to entertain alternative ideas. @priyawadhwa wrote the gvisor addon and may have additional guidance.

Feel free to find me on the #minikube slack channel if you have any questions that are better addressed in real time. Thanks for contributing this change!

@grahamwhaley
Copy link

Hi @tstromberg - ah, thanks for the roadmap link - afaik nobody in the Kata community knew about that - but, now we do! ;-)
I started using Minikube to do quick Kata demos/workshops recently, as it is a nice way to get a small cluster up etc. At that time I also considered what it would take to get Kata as a native component into Minikube. Let me go have a look what it took for gvisor and see if that maps at all to how Kata is built/installed/released. It would be nice if we can have Kata releases automatically updating in Minikube etc.

Which leads me to another couple of questions then:

  1. Do we know when this PR will land in a Minikube release? Is there a release roadmap etc. - so I know what to document/tell folks in Kata-land about which Minikube versions work with which setups etc.

  2. Does minikube run a CI system? In which case maybe we can get it to install Kata and run our tests - that, and/or, we'd probably like to do a similar thing in our Kata CI - to check that we don't break minikube integration either.

@grahamwhaley
Copy link

FMI, the PR to add gvisor looks to be #3399
@amshinde @egernst - this looks quite like it uses a pod to deploy much like kata-deploy (in fact, was there some 'inspiration' there??). That might make it not too onerous to add Kata to Minikube.

We should probably open a new Issue here on Minikube to track this...

@amshinde
Copy link
Contributor Author

@grahamwhaley Yes, I did have a brief look at that PR last week, and much of it is essentially what kata-deploy does.
@grahamwhaley In case you missed it, @tstromberg has opened #4347 to track the support for Kata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants