-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kernel: Add config for tc u32 filter and mirred action #4340
Conversation
These are needed for running Kata Containers in minikube. Kata uses linux tc for its networking Signed-off-by: Archana Shinde <[email protected]>
Welcome @amshinde! |
Hi @amshinde. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amshinde If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Thank you! The test failure is an unrelated flake. |
@minikube-bot ok to test |
As a side note, I am really excited about the possibility of running Kata containers in minikube. Please let me know if there is anything else I can do to help. |
Hi @tstromberg - sure - the original issue turned up as I was documenting how to install/run kata under minikube: kata-containers/documentation#445 So, what would it take to get Kata as a supported option in minikube, like I think I have seen gvisor is ? If we can work together on that, that would be great :-) |
You know, I'm not actually sure what it will take, but I'm happy to help point you in the right direction. When the maintainers came up with the minikube development roadmap for 2019, we identified that we wanted support for Kata containers, but no one has yet stepped up to look into it. I think Kata Containers have a great design and would personally love to see support for it. I've now opened an issue I agree that following the gvisor addon is a good approach, but if for some reason it's too complicated to include as an addon, I'm happy to entertain alternative ideas. @priyawadhwa wrote the gvisor addon and may have additional guidance. Feel free to find me on the #minikube slack channel if you have any questions that are better addressed in real time. Thanks for contributing this change! |
Hi @tstromberg - ah, thanks for the roadmap link - afaik nobody in the Kata community knew about that - but, now we do! ;-) Which leads me to another couple of questions then:
|
FMI, the PR to add We should probably open a new Issue here on Minikube to track this... |
@grahamwhaley Yes, I did have a brief look at that PR last week, and much of it is essentially what |
These are needed for running Kata Containers in minikube.
Kata uses linux tc for its networking
Signed-off-by: Archana Shinde [email protected]