-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kvm network name validation #4380
Add kvm network name validation #4380
Conversation
Hi @josedonizetti. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
@minikube-bot OK to test |
Thanks again for all of these fixes. I feel much better about the kvm2 driver now. It may very well become our most robust driver after all this. |
@minikube-bot OK to test |
@josedonizetti please squash the commit to one |
cf7cfe0
to
9db0975
Compare
@RA489 commit squashed |
@josedonizetti Thanks! |
/ok-to-test |
@minikube-bot OK to test |
/retest this please |
The failing test is related to this flaky test #4501 |
Fix for #3581
I think it makes sense to validate this inside the driver. But maybe we could also add a check on the cli for the
--kvm-network
flag. WDYT?