Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete profile folder instead of just config.json #4572

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

fenglixa
Copy link
Contributor

There will left a blank profile folder there after execute minikube delete. Fix it.

Fix #4570

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fenglixa
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 24, 2019
@fenglixa
Copy link
Contributor Author

fenglixa commented Jun 24, 2019

@RA489 could you please help review? Thanks very much

@fenglixa fenglixa changed the title Delete profile dir instead of just config.json Delete profile folder instead of just config.json Jun 24, 2019
@RA489
Copy link

RA489 commented Jun 24, 2019

@fenglixa Thanks! for the PR

@RA489
Copy link

RA489 commented Jun 24, 2019

@minikube-bot OK to test

@fenglixa
Copy link
Contributor Author

Thanks @RA489
I append my UT result here as well:
image

@fenglixa
Copy link
Contributor Author

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jun 24, 2019

This is really good ! thank you so much for fixing it ! @fenglixa

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution ! I really like it !

@medyagh medyagh merged commit 467d8c9 into kubernetes:master Jun 24, 2019
@fenglixa
Copy link
Contributor Author

Thanks @medyagh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete operation should delete profiles/<profile> folder rather than only delete config.json file
5 participants