Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New repo for kubernetes-incubator/external-storage/local-volume #244

Closed
cofyc opened this issue Nov 15, 2018 · 12 comments · Fixed by kubernetes/community#3033
Closed

New repo for kubernetes-incubator/external-storage/local-volume #244

cofyc opened this issue Nov 15, 2018 · 12 comments · Fixed by kubernetes/community#3033
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@cofyc
Copy link
Member

cofyc commented Nov 15, 2018

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

sig-storage-local-static-provisioner

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

@msau42
@saad-ali
@jsafrane

If not a staging repo, who should have write access

If a new repo, who should be listed as approvers in OWNERS

@msau42
@saad-ali
@wongma7
@jsafrane
@dhirajh
@cofyc

If a new repo, who should be listed in SECURITY_CONTACTS

@msau42
@saad-ali
@jsafrane

What should the repo description be

Static provisioner of local volumes

What SIG and subproject does this fall under in sigs.yaml

sig-storage

Approvals

Need sig-storage approval from: @childsb, @saad-ali and @msau42
See "Break out local-provisioner from external-storage repo" in https://docs.google.com/spreadsheets/d/1t4z5DYKjX2ZDlkTpCnp18icRAQqOE85C1T1r2gqJVck/edit#gid=1566770776

Additional context for request

Current, kubernetes-incubator/external-storage houses a lot of different provisioners. Different provisioners may have theirs own dependency/ci requirements, etc. For dependency management, it resulted that external-storage repo has huge dependency chain, and updating dependencies for one provisioner requires updating it for all provisioners which is not convenient and may have risk. So we are going to break out local-provisioner from external-storage repo first.

/area github-repo

@k8s-ci-robot k8s-ci-robot added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Nov 15, 2018
@cofyc
Copy link
Member Author

cofyc commented Nov 15, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 15, 2018
@msau42
Copy link
Member

msau42 commented Nov 15, 2018

@jsafrane @gnufied what do you think of the repo name and description?

@jsafrane
Copy link
Member

Name sounds good, description could be IMO more descriptive, like "Static provisioner of local volumes" or something that says what it provisions.

@cofyc
Copy link
Member Author

cofyc commented Nov 15, 2018

Updated.

@msau42
Copy link
Member

msau42 commented Nov 19, 2018

Maybe the description should emphasize that it does not do dynamic provisioning. Something like "The local volume static provisioner manages the PersistentVolume lifecycle for pre-allocated disks by detecting and creating PVs for each local disk on the host, and cleaning up the disks when released. It does not support dynamic provisioning."

@cofyc
Copy link
Member Author

cofyc commented Nov 20, 2018

I think this repo description is only used as initial description value on repo creation, we can change it later. And I think it's better to add this long detail description in README.md file.

@cblecker
Copy link
Member

Waiting on explicit sig-storage approval on this one

@msau42
Copy link
Member

msau42 commented Nov 20, 2018

/lgtm

@saad-ali
Copy link
Member

Approved on behalf of SIG Storage.

@cofyc
Copy link
Member Author

cofyc commented Nov 29, 2018

/assign @cblecker

@cblecker
Copy link
Member

@cofyc
Copy link
Member Author

cofyc commented Dec 17, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants