Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a number of repos to k/community #3033

Merged
merged 9 commits into from
Dec 20, 2018
Merged

Add a number of repos to k/community #3033

merged 9 commits into from
Dec 20, 2018

Conversation

cblecker
Copy link
Member

@cblecker cblecker commented Dec 17, 2018 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Dec 17, 2018
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 17, 2018
@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Dec 17, 2018
dims
dims reviewed Dec 17, 2018
View reviewed changes
sig-api-machinery/README.md
@@ -92,6 +92,9 @@ The following subprojects are owned by sig-api-machinery:
- https://raw.githubusercontent.com/kubernetes-incubator/client-python/master/OWNERS
- https://raw.githubusercontent.com/kubernetes/client-go/master/OWNERS
- https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/src/k8s.io/client-go/OWNERS
- **yaml**
- Owners:
- https://raw.githubusercontent.com/kubernetes-sigs/yaml/master/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cblecker !!

dims
dims reviewed Dec 17, 2018
View reviewed changes
sig-architecture/README.md
@@ -58,6 +58,9 @@ The following subprojects are owned by sig-architecture:
- https://raw.githubusercontent.com/kubernetes/kubernetes/master/vendor/OWNERS
- https://raw.githubusercontent.com/kubernetes/kubernetes/master/third_party/OWNERS
- https://raw.githubusercontent.com/kubernetes/kubernetes/master/staging/OWNERS
- **klog**
- Owners:
- https://raw.githubusercontent.com/kubernetes/klog/master/OWNERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cblecker !

@dims
Copy link
Member

dims commented Dec 17, 2018

/lgtm
/hold

@cblecker holding for some more acks for other repos. please unhold when appropriate.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 17, 2018
@nikhita nikhita mentioned this pull request Dec 20, 2018
Closed
@cblecker
Copy link
Member Author

I'm going to get this merged in, and then we can iterate.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 41e40f2 into kubernetes:master Dec 20, 2018
@cblecker cblecker deleted the repo-updates branch December 20, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@brancz brancz Awaiting requested review from brancz

@calebamiles calebamiles Awaiting requested review from calebamiles

Assignees

@dims dims

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@cblecker @k8s-ci-robot @dims @spiffxp