Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the rpm manifest with the deb ones #197

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

luxas
Copy link
Member

@luxas luxas commented Nov 7, 2016

@@ -5,7 +5,7 @@

Name: kubelet
Version: %{KUBE_VERSION}
Release: %{RPM_RELEASE}
Release: %{RPM_RELEASE}.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just bump the RPM_RELEASE counter here to signal a packaging change not an actual software change. Same for the .0 below.

@@ -20,9 +20,14 @@ Source5: https://storage.googleapis.com/kubernetes-release/network-plugins/cni-a

BuildRequires: curl
Requires: iptables >= 1.4.21
Requires: kubernetes-cni >= 0.3.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a required package? I thought that was optional.

Requires: socat
Requires: util-linux
Requires: ethtool
Requires: iproute2
Copy link

@bjornl bjornl Nov 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have this been tested? AFAIK there is no package named iproute2 on RHEL and CentOS 7. This dependency can not be meet.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, found and fixed recently in #212 but this hasn't made it to unstable yet.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgoodwin any ETA on the unstable repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afraid I'm not sure, @mikedanese @luxas could we get a new unstable build going soon? It's currently quite busted on CentOS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can do one today

marpaia pushed a commit to marpaia/release that referenced this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants