Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate DEB/RPM build and sign + publish #2708

Merged

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Ensures we don't partially publish Packages after completing builds of Debians then failing to build RPMs, making it much easier for operators to resume the script (vs previously having to manually editing the script)
  • Makes it possible to run the build, sign + publish steps of package publishing independently
  • Cleans up the bash a bit, to follow better practices (DRY, no dependency on $(pwd) of the calling environment being the repo root)

Which issue(s) this PR fixes:

Special notes for your reviewer:

THIS IS BEST REVIEWED COMMIT BY COMMIT

I've prepared this PR so the first commit simply makes two additional copies of k8s-rapture.sh

Then subsequent commits transform them, so you can see which lines are actually added or removed to each step, instead of having to read totally net-new bash files (most of the script lines are exactly as written in the combined k8s-rapture they came from, the changes to fix those are broken down).

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2022
@BenjaminKazemi
Copy link

Thanks for making these changes Ben!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@BenjaminKazemi
Copy link

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenjaminKazemi, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0f1211a into kubernetes:master Oct 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 13, 2022
@BenTheElder BenTheElder deleted the seperate-build-and-sign-publish branch October 13, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants