-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate DEB/RPM build and sign + publish #2708
Merged
k8s-ci-robot
merged 5 commits into
kubernetes:master
from
BenTheElder:seperate-build-and-sign-publish
Oct 13, 2022
Merged
Separate DEB/RPM build and sign + publish #2708
k8s-ci-robot
merged 5 commits into
kubernetes:master
from
BenTheElder:seperate-build-and-sign-publish
Oct 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will make it easier to review the diff in the next commits where we make the necessary changes to pare down each to the respective portions
- use more robust path management - update copyright year
k8s-ci-robot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-priority
area/release-eng
Issues or PRs related to the Release Engineering subproject
sig/release
Categorizes an issue or PR as relevant to SIG Release.
labels
Oct 13, 2022
k8s-ci-robot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Oct 13, 2022
Thanks for making these changes Ben! |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Oct 13, 2022
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenjaminKazemi, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Oct 13, 2022
Closed
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/release-eng
Issues or PRs related to the Release Engineering subproject
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
release-note-none
Denotes a PR that doesn't merit a release note.
sig/release
Categorizes an issue or PR as relevant to SIG Release.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
$(pwd)
of the calling environment being the repo root)Which issue(s) this PR fixes:
Special notes for your reviewer:
THIS IS BEST REVIEWED COMMIT BY COMMIT
I've prepared this PR so the first commit simply makes two additional copies of k8s-rapture.sh
Then subsequent commits transform them, so you can see which lines are actually added or removed to each step, instead of having to read totally net-new bash files (most of the script lines are exactly as written in the combined k8s-rapture they came from, the changes to fix those are broken down).
Does this PR introduce a user-facing change?