Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce requiring milestone on k/k for merge #321

Closed
justaugustus opened this issue Sep 29, 2018 · 7 comments
Closed

Enforce requiring milestone on k/k for merge #321

justaugustus opened this issue Sep 29, 2018 · 7 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@justaugustus
Copy link
Member

/sig release
/help

rel: kubernetes/community#2408

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/sig release
/help

rel: kubernetes/community#2408

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 29, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 15, 2018

As discussed during release 1.13 meeting and retro, this seems like it's undue friction to impose early in the release cycle.

ref: #243 (comment) for a summary of the discussion we had around this in July

@justaugustus
Copy link
Member Author

justaugustus commented Oct 24, 2018

To add more context...
While we did mention the idea during the 1.12 retro, we did not have the time to dive in. The referenced issue above also does not make any determination on this.

I do believe requiring milestone for all merges would create some additional friction, but I don't think that that friction is undue. Overall, I feel it would serve to relieve some of the triage burden for the release team.

I've added this as an agenda item for the 11/6 SIG Release meeting.
/cc @calebamiles @jdumars @tpepper @AishSundar @jberkus

@tpepper
Copy link
Member

tpepper commented Nov 20, 2018

Discussed in Nov. 20 SIG Release meeting: no solid recollections of justifications for going back to this. Nobody's clamoring for it. If something were to be implemented, all felt it must be more automated, and that would be in support of easier GitHub-based discovery of PRs in a given milestone.

@nikopen
Copy link
Contributor

nikopen commented Nov 20, 2018

+1 - enforcing it can be a burden, but instead the bot can automatically apply the milestone to anything that merges against the upcoming release. This way anyone can use the github UI / search queries to easily see what went in.

@justaugustus
Copy link
Member Author

justaugustus commented Nov 21, 2018

I caught up on yesterday's SIG Release meeting.
For context, I opened this issue because we kind of sped through this on the 1.12 Retro and I wanted to make sure we had a firm decision around whether or not this was of value.

Given the discussion on the call, I'm satisfied and happy to close this now. :)
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

I caught up on yesterday's SIG Release meeting.
For context, I opened this because we kind of sped through this on the 1.12 Retro and I wanted to make sure we had a firm decision around whether this was of value.

Given the discussion on the call, I'm satisfied and happy to close this now. :)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

5 participants