-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce requiring milestone on k/k for merge #321
Comments
@justaugustus: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As discussed during release 1.13 meeting and retro, this seems like it's undue friction to impose early in the release cycle. ref: #243 (comment) for a summary of the discussion we had around this in July |
To add more context... I do believe requiring milestone for all merges would create some additional friction, but I don't think that that friction is undue. Overall, I feel it would serve to relieve some of the triage burden for the release team. I've added this as an agenda item for the 11/6 SIG Release meeting. |
Discussed in Nov. 20 SIG Release meeting: no solid recollections of justifications for going back to this. Nobody's clamoring for it. If something were to be implemented, all felt it must be more automated, and that would be in support of easier GitHub-based discovery of PRs in a given milestone. |
+1 - enforcing it can be a burden, but instead the bot can automatically apply the milestone to anything that merges against the upcoming release. This way anyone can use the github UI / search queries to easily see what went in. |
I caught up on yesterday's SIG Release meeting. Given the discussion on the call, I'm satisfied and happy to close this now. :) |
@justaugustus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig release
/help
rel: kubernetes/community#2408
The text was updated successfully, but these errors were encountered: