Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a GitHub Issue Gatherer to link issues to tests in TestGrid #10701

Closed
michelle192837 opened this issue Jan 11, 2019 · 10 comments
Closed

Write a GitHub Issue Gatherer to link issues to tests in TestGrid #10701

michelle192837 opened this issue Jan 11, 2019 · 10 comments
Assignees
Labels
area/testgrid kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@michelle192837
Copy link
Contributor

With issue_state.proto out, it's now possible to write a tool that crawls GitHub issues for issues that mention a failing test, and write the info about that issue such that TestGrid can read it! (Or rather, it's ALMOST possible; this requires a small change internally as well to pick up the issue_state proto itself when updating dashboards).

Tagging this 'help-wanted' as it's a feature that 1) I currently don't have bandwidth for, but 2) a helpful contributor could tackle if they're so inclined. ^^ Feel free to ask questions or discuss the design for such a tool.

This should come with a proposal for a change in config.yaml for a more useful file_bug_template, so people monitoring TestGrid dashboards can easily manually-file a bug when a failure occurs, and that bug can be linked to the failing test.

/area testgrid
/help

@michelle192837 michelle192837 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 11, 2019
@k8s-ci-robot k8s-ci-robot added area/testgrid help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 11, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2019
@michelle192837
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 11, 2019
@chases2
Copy link
Contributor

chases2 commented May 23, 2019

I'm currently working on a solution for this feature. It consists of three parts described briefly in the readme, but the idea is as follows:

Part 1: "GitHub Issue Scraper": get data from GitHub API to a gostruct:

type GitHubIssue struct {
	IssueId     string
	Title       string
	Comments    []string
	Body        string
}

Part 2: "Target Identifier": get data from that struct to this struct/proto: issue_state.pb.go

Part 3: Write the proto so that TestGrid can consume it

@spiffxp
Copy link
Member

spiffxp commented Jun 3, 2019

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 3, 2019
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 4, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 6, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 7, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 7, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 7, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
@chases2
Copy link
Contributor

chases2 commented Jun 7, 2019

/assign

chases2 added a commit to chases2/test-infra that referenced this issue Jun 10, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
chases2 added a commit to chases2/test-infra that referenced this issue Jun 10, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
mirandachrist pushed a commit to mirandachrist/test-infra that referenced this issue Jun 17, 2019
A new controller that pins together issues and test targets
Issue kubernetes#10701
@spiffxp
Copy link
Member

spiffxp commented Jul 25, 2019

/milestone v1.16
I believe this is intended for Q3 yes @michelle192837 ?

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 25, 2019
@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 25, 2019
@michelle192837
Copy link
Contributor Author

Correct! Sean's done a lot of the work to do this, need a few more adjustments to actually have it run and used.

@chases2
Copy link
Contributor

chases2 commented Aug 19, 2019

pin: maintenance-ci-testgrid-config-upload

@chases2
Copy link
Contributor

chases2 commented Sep 4, 2019

The pin is being picked up by Entomologist, and is now showing up on Testgrid

Bug

There are many more enhancements to this process that can be made, but the feature is in place.
/close

@k8s-ci-robot
Copy link
Contributor

@chases2: Closing this issue.

In response to this:

The pin is being picked up by Entomologist, and is now showing up on Testgrid

Bug

There are many more enhancements to this process that can be made, but the feature is in place.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testgrid kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

5 participants