Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make critical jobs Guaranteed Pod QOS: pull-kubernetes-verify #18597

Closed
spiffxp opened this issue Aug 1, 2020 · 8 comments · Fixed by #18610
Closed

Make critical jobs Guaranteed Pod QOS: pull-kubernetes-verify #18597

spiffxp opened this issue Aug 1, 2020 · 8 comments · Fixed by #18610
Assignees
Labels
area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Aug 1, 2020

What should be cleaned up or changed:

This is part of #18530

The following jobs should be Guaranteed Pod QOS, meaning they should have CPU and memory resource limits, and matching resource requests:

  • pull-kubernetes-verify

These jobs run on (google.com only) k8s-prow-build, so @spiffxp has provided the following guess:

  • suggest 7 cpu, 10Gi mem

General steps to follow:

/sig testing
/sig release
/area jobs
/area release-eng

@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 1, 2020
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 1, 2020
@spiffxp spiffxp added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 1, 2020
@hasheddan
Copy link
Contributor

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Aug 3, 2020

/remove-help
/assign @hasheddan
/reopen
Holding open to verify the job is healthy after some soak time

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Reopened this issue.

In response to this:

/remove-help
/assign @hasheddan
/reopen
Holding open to verify the job is healthy after some soak time

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Aug 3, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 3, 2020

So far so good

Thought I'd found some suspicious runs in #18610 (comment) but agree with @hasheddan they're expected behavior for PRs that have been force-pushed (abort any previously running jobs, trigger new ones to pick up the new commit)

@spiffxp
Copy link
Member Author

spiffxp commented Aug 3, 2020

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 3, 2020
@hasheddan
Copy link
Contributor

Looks like a timeout on this run. See kubernetes/kubernetes#93387 (comment)

@RobertKielty
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@RobertKielty: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants