Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypicker only applied a single cherrypick #21684

Closed
howardjohn opened this issue Apr 6, 2021 · 5 comments · Fixed by #21888
Closed

Cherrypicker only applied a single cherrypick #21684

howardjohn opened this issue Apr 6, 2021 · 5 comments · Fixed by #21888
Assignees
@matthyx
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.22

Comments

@howardjohn
Copy link
Contributor

What happened:

In PR istio/istio#31798, the cherrypicker only applied to release-1.8

What you expected to happen:

Cherrypick applies to release-1.9 as well

How to reproduce it (as minimally and precisely as possible):

Not sure, see PR above for context

Please provide links to example occurrences, if any:

istio/istio#31798
@howardjohn howardjohn added the kind/bug Categorizes issue or PR as related to a bug. label Apr 6, 2021
@alvaroaleman alvaroaleman mentioned this issue Apr 9, 2021
Closed
@alvaroaleman
Copy link
Member

Possibly a duplicate of #21714

@BenTheElder BenTheElder added the area/prow Issues or PRs related to prow label Apr 11, 2021
@matthyx
Copy link
Contributor

matthyx commented Apr 21, 2021

/assign

@matthyx
Copy link
Contributor

matthyx commented Apr 21, 2021

@howardjohn I think in this case it failed to create the cherry pick for release-1.8 and stopped here:

test-infra/prow/external-plugins/cherrypicker/server.go

Line 374 in ef7abaa

l.WithError(err).Error("failed to create cherrypick")

If you want, I could change the code to try on all branches and report an aggregated error at the end, instead of stopping at the first one.

@matthyx matthyx mentioned this issue Apr 21, 2021
Merged
@howardjohn
Copy link
Contributor Author

Great! thank you

@spiffxp
Copy link
Member

spiffxp commented Aug 11, 2021

/sig testing
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 11, 2021
@dprotaso dprotaso mentioned this issue Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthyx matthyx

Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.22
Development

Successfully merging a pull request may close this issue.

Cherrypick: try to create all picks and return aggregate error matthyx/test-infra
6 participants
@spiffxp @howardjohn @BenTheElder @alvaroaleman @k8s-ci-robot @matthyx