Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherrypick plugin doesn't response to all commands in a github comment #21714

Closed
dprotaso opened this issue Apr 8, 2021 · 5 comments · Fixed by #21885
Closed

cherrypick plugin doesn't response to all commands in a github comment #21714

dprotaso opened this issue Apr 8, 2021 · 5 comments · Fixed by #21885
Assignees
@matthyx
Labels
area/prow Issues or PRs related to prow help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.22

Comments

@dprotaso
Copy link

dprotaso commented Apr 8, 2021

What happened:
cherry-pick plugin didn't detect multiple uses of /cherry-pick command in the same message

ie. from knative/serving#11127 (comment)

/cherry-pick release-0.22
/cherry-pick release-0.21

What you expected to happen:
It would schedule two cherry picks

How to reproduce it (as minimally and precisely as possible):

Please provide links to example occurrences, if any:

Anything else we need to know?:
@dprotaso dprotaso added the kind/bug Categorizes issue or PR as related to a bug. label Apr 8, 2021
@alvaroaleman
Copy link
Member

/area prow
/help
Possibly a duplicate of #21684

@k8s-ci-robot
Copy link
Contributor

@alvaroaleman:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/area prow
/help
Possibly a duplicate of #21684

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 9, 2021
@alvaroaleman alvaroaleman mentioned this issue Apr 9, 2021
Closed
@matthyx
Copy link
Contributor

matthyx commented Apr 21, 2021

/assign

@matthyx
Copy link
Contributor

matthyx commented Apr 21, 2021

I think it's clear:

test-infra/prow/external-plugins/cherrypicker/server.go

Line 292 in ef7abaa

// TODO: Support comments with multiple cherrypick invocations.

I'll do that.

@matthyx matthyx mentioned this issue Apr 21, 2021
Merged
@dprotaso dprotaso mentioned this issue May 5, 2021
Closed
@spiffxp
Copy link
Member

spiffxp commented Aug 11, 2021

/sig testing
/milestone v1.22

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 11, 2021
@dprotaso dprotaso mentioned this issue Sep 2, 2021
Merged
@dprotaso dprotaso mentioned this issue Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthyx matthyx

Labels
area/prow Issues or PRs related to prow help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.22
Development

Successfully merging a pull request may close this issue.

Cherrypick: support multiple calls per comment matthyx/test-infra
5 participants
@dprotaso @spiffxp @alvaroaleman @k8s-ci-robot @matthyx