/cherrypick <branch> doesn't work in k/k

[deads2k]

Can we enable the cherrypick plugin for the CI infrastructure that allows /cherrypick <branch> to cause the bot to cherrypick the pull on top of the chosen branch, create a new pull, and assign it. It's a really handy one to have for maintenance.

@Kargakis @stevekuznetsov what's that plugin called?

/cc @dims

[dims]

i think it's this one https://github.com/kubernetes/test-infra/tree/master/prow/external-plugins/cherrypicker

[0xmichalis]

There is some back n forth in #7393 but hasn't led to anywhere yet

[nikhita]

/cc @cblecker @guineveresaenger

[stevekuznetsov]

IIRC @cblecker had some reservations

[BenTheElder]

Yep, I'm open to PRs for this, but there's been so much back and forth I don't think anyone here has had bandwidth to set it up.

[stevekuznetsov]

I think #7393 has all the work -- if you want to use a separate bot, someone needs to make it, otherwise that is all?

[BenTheElder]

Yes that was the feedback, use fejta-bot or a new token. We don't need to pile more things on k8s-ci-robot

…

On Wed, Sep 26, 2018, 18:15 Steve Kuznetsov ***@***.***> wrote: I think #7393 <#7393> has all the work -- if you want to use a separate bot, someone needs to make it, otherwise that is all? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4Bq9YtCZi--rp1Zxl_lXbatOKyQeO-ks5ufCbKgaJpZM4W6i9s> .

[stevekuznetsov]

Aside from that though, @cblecker had other feedback. Also, EngProd would need to create the cherry pick robot anyway, right?

[BenTheElder]

What's wrong with fejta-bot?

…

On Wed, Sep 26, 2018, 19:23 Steve Kuznetsov ***@***.***> wrote: Aside from that though, @cblecker <https://github.com/cblecker> had other feedback. Also, EngProd would need to create the cherry pick robot anyway, right? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9582 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA4Bq9XF71umXELIdaMx90PzKBS2VBonks5ufDaYgaJpZM4W6i9s> .

[stevekuznetsov]

Nothing (serious) I can think of that would block an implementation using that token.

[stevekuznetsov]

Having k8s-cherrypick-bot may be clearer, though - we have seen confusion about @fejta-bot before. Would also ensure we don't add any undue token pressure.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[nikhita]

/remove-lifecycle stale
/kind feature
/sig contributor-experience

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[stevekuznetsov]

/remove-lifecycle stale

What's the blocker here? Creating a new account is simple, right?

[cjwagner]

Yes creating a new account is easy.
The contributor experience concerns are the main blocker I think. Thread starts here: #7393 (comment)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[stevekuznetsov]

/remove-lifecycle stale

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.