Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy all the rbac rules for prow.k8s.io #9867

Closed
krzyzacy opened this issue Oct 19, 2018 · 24 comments
Closed

deploy all the rbac rules for prow.k8s.io #9867

krzyzacy opened this issue Oct 19, 2018 · 24 comments
Assignees
@fejta @cjwagner
Labels
area/prow Issues or PRs related to prow lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@krzyzacy
Copy link
Member

we have them committed but not deployed, also deployers will need to get their own clusterrole first, so, clean up time :-)

cc maintainer of k8s-prow: @fejta @BenTheElder @cjwagner @amwat @ixdy
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2019
@krzyzacy
Copy link
Member Author

/remove-lifecycle stale

we have rbac for newly-added controllers at least..

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2019
@stevekuznetsov
Copy link
Contributor

/remove-lifecycle stale
/cc @cjwagner

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2019
@cjwagner
Copy link
Member

See #12230 (comment)
I think that we'll need to recreate the cluster to disable legacy authentication. If that is the case then this is probably something we should change when switching to a CNCF owned Prow cluster.

@stevekuznetsov
Copy link
Contributor

Oh I thought you had enabled RBAC when the migration happened between versions

@stevekuznetsov
Copy link
Contributor

Do you imagine that will be hard to do in the current cluster? Why?

@cjwagner
Copy link
Member

I thought we'd need to recreate the cluster to disable legacy authentication. It looks like that might not be true though.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 24, 2019

/remove-lifecycle stale
/milestone v1.16
/assign @cjwagner
where do we stand with this?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 24, 2019
@spiffxp
Copy link
Member

spiffxp commented Jul 24, 2019

/area prow

@k8s-ci-robot k8s-ci-robot added the area/prow Issues or PRs related to prow label Jul 24, 2019
@cjwagner
Copy link
Member

cjwagner commented Jul 24, 2019 •
edited
Loading

It looks like we can enable legacy authorization without recreating a new cluster. If that's the case we just need to deploy all the RBAC rules and flip the switch.
It is possible that our RBAC rules will be missing some necessary permissions though since we haven't required RBAC thus far so we'll want to be ready to quickly add any permissions we missed after flipping the switch.

@stevekuznetsov stevekuznetsov changed the title deploy all the rbac rules for k8s.prow deploy all the rbac rules for prow.k8s.io Jul 24, 2019
@stevekuznetsov
Copy link
Contributor

If just do a review to make sure the rules are in sync with what OpenShift runs you should hit no issues

@spiffxp spiffxp added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 25, 2019
@cjwagner
Copy link
Member

Lets follow this suggestion too: #8288 (comment)

@aegershman aegershman mentioned this issue Aug 15, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2019
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 24, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta fejta reopened this Feb 20, 2020
@fejta fejta mentioned this issue Feb 20, 2020
Merged
@fejta
Copy link
Contributor

fejta commented Feb 20, 2020

ref #15806

@fejta
Copy link
Contributor

fejta commented Feb 20, 2020

/remove-lifecycle rotten
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 20, 2020
This was referenced Feb 20, 2020
Merged
Merged
Merged
@spiffxp spiffxp removed this from the v1.16 milestone Apr 16, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 15, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fejta fejta

@cjwagner cjwagner

Labels
area/prow Issues or PRs related to prow lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@spiffxp @fejta @krzyzacy @cjwagner @stevekuznetsov @k8s-ci-robot @fejta-bot