Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable tide for cloud-provider-sample #10569

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Enable tide for cloud-provider-sample #10569

merged 1 commit into from
Jan 19, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Dec 28, 2018 •
edited
Loading

cloud-provider-sample is a new repo in the Kubernetes org: kubernetes/org#314.

This is required for kubernetes/cloud-provider-sample#1 to merge.

/cc @cblecker @spiffxp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/prow Issues or PRs related to prow labels Dec 28, 2018
@nikhita
Copy link
Member Author

nikhita commented Dec 28, 2018

/cc @tallclair
for node-api

/cc @cheftako
for cloud-provider-sample

@cblecker
Copy link
Member

/hold

Isn’t node-api a staging repo?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 28, 2018
@cheftako
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0bb088bb12042784716dacd07f2ce5be94015317

@nikhita
Enable tide for cloud-provider-sample
0d6768d 
This is a new repo created in the Kubernetes org.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2018
@nikhita nikhita changed the title Enable tide for node-api and cloud-provider-sample repos Enable tide for loud-provider-sample Dec 30, 2018
@nikhita
Copy link
Member Author

nikhita commented Dec 30, 2018

Isn’t node-api a staging repo?

Yes, got confused by seeing client-go in the list 🤦‍♀️ (but client-go is different because it does have some authoritative files in the published repo).

Removed node-api. 👍

@nikhita nikhita changed the title Enable tide for loud-provider-sample Enable tide for cloud-provider-sample Dec 30, 2018
cheftako
cheftako reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c14c19576cfb2cbe0ca4dfacd7073afc76091a29

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2019
cblecker
cblecker approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @cjwagner

cjwagner
cjwagner approved these changes Jan 5, 2019
View reviewed changes
Copy link
Member

@cjwagner cjwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spiffxp Any reason for us to keep listing all the Kubernetes repos individually or can we switch to using org: kubernetes -repo:kubernetes/kubernetes with the excludedRepos field?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cjwagner, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2019
@spiffxp spiffxp mentioned this pull request Jan 19, 2019
Closed
@spiffxp
Copy link
Member

spiffxp commented Jan 19, 2019

/hold cancel
Opened #10846 for changing the query

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 38bfb6c into kubernetes:master Jan 19, 2019
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the config configmap using the following files:

  • key config.yaml using file prow/config.yaml

In response to this:

cloud-provider-sample is a new repo in the Kubernetes org: kubernetes/org#314.

This is required for kubernetes/cloud-provider-sample#1 to merge.

/cc @cblecker @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita nikhita deleted the enable-tide-for-new-repos branch January 19, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako left review comments

@cjwagner cjwagner cjwagner approved these changes

@cblecker cblecker cblecker approved these changes

@spiffxp spiffxp Awaiting requested review from spiffxp

@tallclair tallclair Awaiting requested review from tallclair

Assignees

@cheftako cheftako

@cblecker cblecker

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhita @cblecker @cheftako @k8s-ci-robot @spiffxp @cjwagner